From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61249C433DF for ; Fri, 12 Jun 2020 11:02:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3C472065C for ; Fri, 12 Jun 2020 11:02:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="NLPxjZvB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3C472065C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 64151166F; Fri, 12 Jun 2020 13:01:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 64151166F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1591959744; bh=yRQ50Z+6K5DgCGMVeVcwNX4/icXLlRsBDrLePCOTvf8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NLPxjZvBj6wwbfCO7/ticb8x2A8iR1Dv0+IC8w0w5BO8zBsqE70K3oLIVAe/D69c4 xBgv2BP3PX1FkA9EPjYEKlBYJnzHfy0eZAl6V20giJMyzU+iM6cMGjbOWv3YSv9EZv TyhPQcIpIX4THNBeai5uYPHqLZNJQQySzr4LOaoQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F276CF801F7; Fri, 12 Jun 2020 13:01:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CD516F8021C; Fri, 12 Jun 2020 13:01:32 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C07EEF800CC; Fri, 12 Jun 2020 13:01:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C07EEF800CC X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0889CAFA0; Fri, 12 Jun 2020 11:01:28 +0000 (UTC) Date: Fri, 12 Jun 2020 13:01:23 +0200 Message-ID: From: Takashi Iwai To: Brent Lu Subject: Re: [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP In-Reply-To: <1591959048-15813-1-git-send-email-brent.lu@intel.com> References: <1591959048-15813-1-git-send-email-brent.lu@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Kai Vehmanen , Liam Girdwood , Bard Liao , Cezary Rojewski , Takashi Iwai , Keyon Jie , Ranjani Sridharan , Pierre-Louis Bossart , Mark Brown , Daniel Baluta , Zhu Yingjiang , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 12 Jun 2020 12:50:48 +0200, Brent Lu wrote: > > Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading > WP") from legacy HDA driver to fix the get response timeout issue. > Current SOF driver does not suffer from this issue because sync write > is enabled in hda_init. The issue will come back if the sync write is > disabled for some reason. > > Signed-off-by: Brent Lu Reviewed-by: Takashi Iwai Thanks! Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D230C433E0 for ; Fri, 12 Jun 2020 11:01:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01C182065C for ; Fri, 12 Jun 2020 11:01:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726310AbgFLLBi (ORCPT ); Fri, 12 Jun 2020 07:01:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:52724 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgFLLBZ (ORCPT ); Fri, 12 Jun 2020 07:01:25 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0889CAFA0; Fri, 12 Jun 2020 11:01:28 +0000 (UTC) Date: Fri, 12 Jun 2020 13:01:23 +0200 Message-ID: From: Takashi Iwai To: Brent Lu Cc: , Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Zhu Yingjiang , Keyon Jie , Bard Liao , , Subject: Re: [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP In-Reply-To: <1591959048-15813-1-git-send-email-brent.lu@intel.com> References: <1591959048-15813-1-git-send-email-brent.lu@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Jun 2020 12:50:48 +0200, Brent Lu wrote: > > Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading > WP") from legacy HDA driver to fix the get response timeout issue. > Current SOF driver does not suffer from this issue because sync write > is enabled in hda_init. The issue will come back if the sync write is > disabled for some reason. > > Signed-off-by: Brent Lu Reviewed-by: Takashi Iwai Thanks! Takashi