From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: mixart_core: Mark expected switch fall-through Date: Thu, 09 Aug 2018 08:52:23 +0200 Message-ID: References: <20180808221148.GA1864@embeddedor.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20180808221148.GA1864@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org To: " Gustavo A. R. Silva " Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Thu, 09 Aug 2018 00:11:48 +0200, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I replaced the code comment with > a proper "fall through" annotation, which is what GCC is expecting > to find. > > Addresses-Coverity-ID: 114889 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Applied, thanks. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C24A0C46464 for ; Thu, 9 Aug 2018 06:52:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FC3221C16 for ; Thu, 9 Aug 2018 06:52:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FC3221C16 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728016AbeHIJPt (ORCPT ); Thu, 9 Aug 2018 05:15:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:40070 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727371AbeHIJPs (ORCPT ); Thu, 9 Aug 2018 05:15:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CA89AAF6F; Thu, 9 Aug 2018 06:52:23 +0000 (UTC) Date: Thu, 09 Aug 2018 08:52:23 +0200 Message-ID: From: Takashi Iwai To: " Gustavo A. R. Silva " Cc: "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: mixart_core: Mark expected switch fall-through In-Reply-To: <20180808221148.GA1864@embeddedor.com> References: <20180808221148.GA1864@embeddedor.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 09 Aug 2018 00:11:48 +0200, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I replaced the code comment with > a proper "fall through" annotation, which is what GCC is expecting > to find. > > Addresses-Coverity-ID: 114889 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Applied, thanks. Takashi