From: Takashi Iwai <tiwai@suse.de>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: patches.audio@intel.com, alsa-devel@alsa-project.org,
broonie@kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH v2] ALSA: hda - Add hdmi id for a Geminilake variant
Date: Wed, 12 Jul 2017 17:09:32 +0200 [thread overview]
Message-ID: <s5h60exk7yr.wl-tiwai@suse.de> (raw)
In-Reply-To: <1499870524-6376-1-git-send-email-subhransu.s.prusty@intel.com>
On Wed, 12 Jul 2017 16:42:04 +0200,
Subhransu S. Prusty wrote:
>
> Few GLK platform variants report a different vendor id. Add it.
> Also add the missing check for GLK in is_haswell_plus().
>
> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Applied, thanks.
Takashi
> ---
>
> v1 -> v2:
> Fix a typo in commit message
> update the commit message to add glk check in is_haswell_plus()
>
> sound/pci/hda/patch_hdmi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index 76c85f08bea6..d549f35f39d3 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -53,9 +53,11 @@
> #define is_skylake(codec) ((codec)->core.vendor_id == 0x80862809)
> #define is_broxton(codec) ((codec)->core.vendor_id == 0x8086280a)
> #define is_kabylake(codec) ((codec)->core.vendor_id == 0x8086280b)
> +#define is_geminilake(codec) (((codec)->core.vendor_id == 0x8086280d) || \
> + ((codec)->core.vendor_id == 0x80862800))
> #define is_haswell_plus(codec) (is_haswell(codec) || is_broadwell(codec) \
> || is_skylake(codec) || is_broxton(codec) \
> - || is_kabylake(codec))
> + || is_kabylake(codec)) || is_geminilake(codec)
>
> #define is_valleyview(codec) ((codec)->core.vendor_id == 0x80862882)
> #define is_cherryview(codec) ((codec)->core.vendor_id == 0x80862883)
> @@ -3790,6 +3792,7 @@ static int patch_via_hdmi(struct hda_codec *codec)
> HDA_CODEC_ENTRY(0x8086280a, "Broxton HDMI", patch_i915_hsw_hdmi),
> HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI", patch_i915_hsw_hdmi),
> HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi),
> +HDA_CODEC_ENTRY(0x80862800, "Geminilake HDMI", patch_i915_glk_hdmi),
> HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi),
> HDA_CODEC_ENTRY(0x80862882, "Valleyview2 HDMI", patch_i915_byt_hdmi),
> HDA_CODEC_ENTRY(0x80862883, "Braswell HDMI", patch_i915_byt_hdmi),
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-07-12 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 14:42 [PATCH v2] ALSA: hda - Add hdmi id for a Geminilake variant Subhransu S. Prusty
2017-07-12 15:09 ` Takashi Iwai [this message]
2017-07-12 16:54 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h60exk7yr.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.