All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] amixer: Don't set only the first item in	sset_enum()
Date: Thu, 05 Mar 2015 11:06:44 +0100	[thread overview]
Message-ID: <s5h61af7o7f.wl-tiwai@suse.de> (raw)
In-Reply-To: <1425404392-22598-1-git-send-email-pmeerw@pmeerw.net>

At Tue,  3 Mar 2015 18:39:52 +0100,
Peter Meerwald wrote:
> 
> From: Peter Meerwald <p.meerwald@bct-electronic.com>
> 
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>

Applied, thanks.


Takashi

> ---
>  amixer/amixer.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/amixer/amixer.c b/amixer/amixer.c
> index ed60e7c..36c92eb 100644
> --- a/amixer/amixer.c
> +++ b/amixer/amixer.c
> @@ -1278,7 +1278,7 @@ static int get_enum_item_index(snd_mixer_elem_t *elem, char **ptrp)
>  
>  static int sset_enum(snd_mixer_elem_t *elem, unsigned int argc, char **argv)
>  {
> -	unsigned int idx, chn = 0;
> +	unsigned int idx, item = 0;
>  	int check_flag = ignore_error ? 0 : -1;
>  
>  	for (idx = 1; idx < argc; idx++) {
> @@ -1287,7 +1287,7 @@ static int sset_enum(snd_mixer_elem_t *elem, unsigned int argc, char **argv)
>  			int ival = get_enum_item_index(elem, &ptr);
>  			if (ival < 0)
>  				return check_flag;
> -			if (snd_mixer_selem_set_enum_item(elem, chn, ival) >= 0)
> +			if (snd_mixer_selem_set_enum_item(elem, item++, ival) >= 0)
>  				check_flag = 1;
>  			/* skip separators */
>  			while (*ptr == ',' || isspace(*ptr))
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

      reply	other threads:[~2015-03-05 10:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 17:39 [PATCH] amixer: Don't set only the first item in sset_enum() Peter Meerwald
2015-03-05 10:06 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h61af7o7f.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.