From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] amixer: Don't set only the first item in sset_enum() Date: Thu, 05 Mar 2015 11:06:44 +0100 Message-ID: References: <1425404392-22598-1-git-send-email-pmeerw@pmeerw.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id D2D0D260410 for ; Thu, 5 Mar 2015 11:06:44 +0100 (CET) In-Reply-To: <1425404392-22598-1-git-send-email-pmeerw@pmeerw.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Peter Meerwald Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Tue, 3 Mar 2015 18:39:52 +0100, Peter Meerwald wrote: > > From: Peter Meerwald > > Signed-off-by: Peter Meerwald Applied, thanks. Takashi > --- > amixer/amixer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/amixer/amixer.c b/amixer/amixer.c > index ed60e7c..36c92eb 100644 > --- a/amixer/amixer.c > +++ b/amixer/amixer.c > @@ -1278,7 +1278,7 @@ static int get_enum_item_index(snd_mixer_elem_t *elem, char **ptrp) > > static int sset_enum(snd_mixer_elem_t *elem, unsigned int argc, char **argv) > { > - unsigned int idx, chn = 0; > + unsigned int idx, item = 0; > int check_flag = ignore_error ? 0 : -1; > > for (idx = 1; idx < argc; idx++) { > @@ -1287,7 +1287,7 @@ static int sset_enum(snd_mixer_elem_t *elem, unsigned int argc, char **argv) > int ival = get_enum_item_index(elem, &ptr); > if (ival < 0) > return check_flag; > - if (snd_mixer_selem_set_enum_item(elem, chn, ival) >= 0) > + if (snd_mixer_selem_set_enum_item(elem, item++, ival) >= 0) > check_flag = 1; > /* skip separators */ > while (*ptr == ',' || isspace(*ptr)) > -- > 1.7.9.5 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >