All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Michael Slade <mslade@knobbits.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Support for Yamaha MOXF
Date: Thu, 09 Jan 2014 07:38:07 +0100	[thread overview]
Message-ID: <s5h61ptpsmo.wl%tiwai@suse.de> (raw)
In-Reply-To: <52CE2EF6.7010902@knobbits.org>

At Thu, 09 Jan 2014 16:09:10 +1100,
Michael Slade wrote:
> 
> My apologies if I'm doing this wrong.
> 
> I have managed to get a Yamaha MOXF8 working with the attached patch.  
> Presumably also works with a MOXF6.
> 
> The new Yamaha MOXF6/8 are successors to the MOX6/8.  Apart from things 
> like new voices, a flash expansion port, and a different colour at the 
> ends, they are pretty much identical in operation.
> 
> The MOXF has a USB ID of 0499:150f.  So I needed to add a new 
> quirks-table.h stanza for it, by copy-pasting the MOX one and changing 
> he ID.
> 
> I haven't tested it to death or anything,  but I am having no trouble 
> recording and playing audio and midi.
> 
> Let me know if this patch is acceptable or of there is more that is 
> needed from me.
> 
> Note, this patch is against Ubuntu Raring's 3.8.0 kernel, but it's a 
> trivial patch.

The code change looks OK, but please reformat the patch in the way to
follow Documentation/SubmittigPatches and resubmit to ML.


thanks,

Takashi

> 
> Mick.
> 
> [2 alsa-yamaha-moxf.patch <text/x-patch (7bit)>]
> --- linux-3.8.0.orig/sound/usb/quirks-table.h
> +++ linux-3.8.0/sound/usb/quirks-table.h
> @@ -353,6 +359,32 @@
>  		}
>  	}
>  },
> +{
> +	USB_DEVICE(0x0499, 0x150f),
> +	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
> +		/* .vendor_name = "Yamaha", */
> +		/* .product_name = "MOXF6/MOXF8", */
> +		.ifnum = QUIRK_ANY_INTERFACE,
> +		.type = QUIRK_COMPOSITE,
> +		.data = (const struct snd_usb_audio_quirk[]) {
> +			{
> +				.ifnum = 1,
> +				.type = QUIRK_AUDIO_STANDARD_INTERFACE
> +			},
> +			{
> +				.ifnum = 2,
> +				.type = QUIRK_AUDIO_STANDARD_INTERFACE
> +			},
> +			{
> +				.ifnum = 3,
> +				.type = QUIRK_MIDI_YAMAHA
> +			},
> +			{
> +				.ifnum = -1
> +			}
> +		}
> +	}
> +},
>  YAMAHA_DEVICE(0x2000, "DGP-7"),
>  YAMAHA_DEVICE(0x2001, "DGP-5"),
>  YAMAHA_DEVICE(0x2002, NULL),
> [3  <text/plain; us-ascii (7bit)>]
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2014-01-09  6:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09  5:09 [PATCH] Support for Yamaha MOXF Michael Slade
2014-01-09  6:38 ` Takashi Iwai [this message]
2014-01-09  7:52 ` Clemens Ladisch
2014-01-09  8:14   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h61ptpsmo.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=mslade@knobbits.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.