From: Takashi Iwai <tiwai@suse.de>
To: Thoralf Freitag <thoralf.freitag@cactus-online.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: Mute LED on HP Pavilion DV7-1160eg
Date: Thu, 06 May 2010 10:16:01 +0200 [thread overview]
Message-ID: <s5h6331tpha.wl%tiwai@suse.de> (raw)
In-Reply-To: <4BDC8CC2.5040507@cactus-online.de>
At Sat, 01 May 2010 22:19:14 +0200,
Thoralf Freitag wrote:
>
> I tried to find a way for switching/control Mute LED on an HP DV 7
> notebook. I found a solution which is very ugly. According the solution
> described here
> (http://mailman.alsa-project.org/pipermail/alsa-devel/2009-April/016126.html)
> I changed the value for LED control in this manner:
>
> diff -u alsa-driver-1.0.23/sound/pci/hda/patch_sigmatel.c
> alsa-driver-1.0.23_b/sound/pci/hda/patch_sigmatel.c
> --- alsa-driver-1.0.23/sound/pci/hda/patch_sigmatel.c 2010-04-16
> 13:10:10.000000000 +0200
> +++ alsa-driver-1.0.23_b/sound/pci/hda/patch_sigmatel.c 2010-05-01
> 21:37:36.719063655 +0200
> @@ -4952,9 +4952,9 @@
> }
> }
> if (muted)
> - spec->gpio_data &= ~spec->gpio_led; /* orange */
> + spec->gpio_data &= ~0x01; /* orange */
> else
> - spec->gpio_data |= spec->gpio_led; /* white */
> + spec->gpio_data |= 0x01; /* white */
>
> if (!spec->gpio_led_polarity) {
> /* LED state is inverted on these systems */
>
> I hate this solution. Maybe someone of the programming experts could
> give me a way to make it better. On which position should I make which
> changes ?
The mute LED is set up in find_mute_led_gpio().
If your BIOS doesn't give the proper information, you can add the device
statically in hp_blike_system().
Takashi
next prev parent reply other threads:[~2010-05-06 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-01 20:19 Mute LED on HP Pavilion DV7-1160eg Thoralf Freitag
2010-05-06 8:16 ` Takashi Iwai [this message]
2010-05-10 20:10 ` Thoralf Freitag
2010-05-10 21:09 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2010-05-19 15:34 [PATCH] ALSA: usb/mixer.c: remove unused variable Daniel Mack
2010-05-19 16:29 ` Takashi Iwai
2010-05-30 22:12 ` Mute LED on HP Pavilion DV7-1160eg Thoralf Freitag
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h6331tpha.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=thoralf.freitag@cactus-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.