From: Takashi Iwai <tiwai@suse.de>
To: Matthew Flint <mkflint@gmail.com>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: Patches for Packard Bell EasyNote laptop support
Date: Wed, 07 Feb 2007 17:58:46 +0100 [thread overview]
Message-ID: <s5h64advr95.wl%tiwai@suse.de> (raw)
In-Reply-To: <s5h8xfaue1f.wl%tiwai@suse.de>
At Wed, 07 Feb 2007 17:29:32 +0100,
I wrote:
>
> At Wed, 7 Feb 2007 15:24:11 +0000,
> Matthew Flint wrote:
> >
> > See https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1134
> >
> >
> > All,
> >
> > Bug report 1134 tracks progress in getting ALSA to work with a Packard
> > Bell laptop, model "EasyNote A8202". There are three simple patches
> > needed against ALSA v1.0.14rc2.
> >
> > Can I ask a for a kind ALSA developer to merge these patches into
> > trunk, for out-of-the-box support in the next release of ALSA drivers?
>
> Could you create a patch file and submit to this ML again?
> The files there are no patches to be applied easily to the latest
> tree. And, we need a proper changelog and sign-off.
>
> The standard rule for the patch is found in News section of ALSA
> BTS.
OK, I took a look a bit more, and wrote a patch for testing.
Could you check whether the patch below works with the latest ALSA
tree? You can get the latest tree from
ftp://ftp.suse.com/pub/projects/alsa/snapshot/driver/
Thanks,
Takashi
---
diff -r fd9f1cc7e78e pci/ac97/ac97_codec.c
--- a/pci/ac97/ac97_codec.c Wed Feb 07 16:04:25 2007 +0100
+++ b/pci/ac97/ac97_codec.c Wed Feb 07 17:57:55 2007 +0100
@@ -143,6 +143,7 @@ static const struct ac97_codec_id snd_ac
{ 0x43525970, 0xfffffff8, "CS4202", NULL, NULL },
{ 0x43585421, 0xffffffff, "HSD11246", NULL, NULL }, // SmartMC II
{ 0x43585428, 0xfffffff8, "Cx20468", patch_conexant, NULL }, // SmartAMC fixme: the mask might be different
+{ 0x43585431, 0xffffffff, "Cx20551", patch_cx20551, NULL },
{ 0x44543031, 0xfffffff0, "DT0398", NULL, NULL },
{ 0x454d4328, 0xffffffff, "EM28028", NULL, NULL }, // same as TR28028?
{ 0x45838308, 0xffffffff, "ESS1988", NULL, NULL },
diff -r fd9f1cc7e78e pci/ac97/ac97_patch.c
--- a/pci/ac97/ac97_patch.c Wed Feb 07 16:04:25 2007 +0100
+++ b/pci/ac97/ac97_patch.c Wed Feb 07 17:52:48 2007 +0100
@@ -1335,6 +1335,12 @@ int patch_conexant(struct snd_ac97 * ac9
ac97->flags |= AC97_CX_SPDIF;
ac97->ext_id |= AC97_EI_SPDIF; /* force the detection of spdif */
ac97->rates[AC97_RATES_SPDIF] = SNDRV_PCM_RATE_48000; /* 48k only */
+ return 0;
+}
+
+int patch_cx20551(struct snd_ac97 *ac97)
+{
+ snd_ac97_update_bits(ac97, 0x5c, 0x01, 0x01);
return 0;
}
diff -r fd9f1cc7e78e pci/ac97/ac97_patch.h
--- a/pci/ac97/ac97_patch.h Wed Feb 07 16:04:25 2007 +0100
+++ b/pci/ac97/ac97_patch.h Wed Feb 07 17:51:20 2007 +0100
@@ -39,6 +39,7 @@ int patch_cirrus_cs4299(struct snd_ac97
int patch_cirrus_cs4299(struct snd_ac97 * ac97);
int patch_cirrus_spdif(struct snd_ac97 * ac97);
int patch_conexant(struct snd_ac97 * ac97);
+int patch_cx20551(struct snd_ac97 * ac97);
int patch_ad1819(struct snd_ac97 * ac97);
int patch_ad1881(struct snd_ac97 * ac97);
int patch_ad1885(struct snd_ac97 * ac97);
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2007-02-07 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 15:24 Patches for Packard Bell EasyNote laptop support Matthew Flint
2007-02-07 16:29 ` Takashi Iwai
2007-02-07 16:58 ` Takashi Iwai [this message]
2007-02-08 20:13 ` Matthew Flint
2007-02-09 11:39 ` Takashi Iwai
2007-02-08 21:15 ` Andrea Gozzi
2007-02-09 11:44 ` Takashi Iwai
2007-02-10 8:54 ` Andrea Gozzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h64advr95.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@lists.sourceforge.net \
--cc=mkflint@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.