From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [RFC 5/7] snd-aoa: add layout-id fabric Date: Mon, 29 May 2006 14:14:59 +0200 Message-ID: References: <20060528190026.754474000@johannes.berg> <20060528190129.503400000@johannes.berg> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mail.suse.de [195.135.220.2]) by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id BB278168 for ; Mon, 29 May 2006 14:14:59 +0200 (MEST) In-Reply-To: <20060528190129.503400000@johannes.berg> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Johannes Berg Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Sun, 28 May 2006 21:00:31 +0200, Johannes Berg wrote: > > The 'fabric' is the thing that pulls all of snd-aoa together, this patch > adds the 'layout' or 'layout-id' fabric that keys off the 'layout-id' > property in the device-tree to pull in the proper modules. It itself loads > if an i2sbus is present with a layout-id (exported in modalias) that it can > use. (snip) > +static void use_layout(struct layout *l) > +{ > + int i; > + > + for (i=0; i + if (l->codecs[i].name) { > + request_module("snd-aoa-codec-%s", l->codecs[i].name); Just from curiosity: Does this work properly? I remember that there was a deadlock when you call request_module() during module probe. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.suse.de (ns.suse.de [195.135.220.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx1.suse.de", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 2CB0E67A63 for ; Mon, 29 May 2006 22:15:04 +1000 (EST) Date: Mon, 29 May 2006 14:14:59 +0200 Message-ID: From: Takashi Iwai To: Johannes Berg Subject: Re: [Alsa-devel] [RFC 5/7] snd-aoa: add layout-id fabric In-Reply-To: <20060528190129.503400000@johannes.berg> References: <20060528190026.754474000@johannes.berg> <20060528190129.503400000@johannes.berg> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , At Sun, 28 May 2006 21:00:31 +0200, Johannes Berg wrote: > > The 'fabric' is the thing that pulls all of snd-aoa together, this patch > adds the 'layout' or 'layout-id' fabric that keys off the 'layout-id' > property in the device-tree to pull in the proper modules. It itself loads > if an i2sbus is present with a layout-id (exported in modalias) that it can > use. (snip) > +static void use_layout(struct layout *l) > +{ > + int i; > + > + for (i=0; i + if (l->codecs[i].name) { > + request_module("snd-aoa-codec-%s", l->codecs[i].name); Just from curiosity: Does this work properly? I remember that there was a deadlock when you call request_module() during module probe. Takashi