From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: ALC658 SPDIF input patch
Date: Tue, 11 Jan 2005 14:18:47 +0100
Message-ID: <s5h6524t87c.wl@alsa2.suse.de>
References: <1784107302@web.de>
Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Return-path: <alsa-devel-admin@lists.sourceforge.net>
In-Reply-To: <1784107302@web.de>
Sender: alsa-devel-admin@lists.sourceforge.net
Errors-To: alsa-devel-admin@lists.sourceforge.net
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
To: Stefan Macher <Stefan.Macher@web.de>
Cc: alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

At Mon, 10 Jan 2005 16:08:46 +0100,
Stefan Macher wrote:
> 
> > 
> > At Sun, 9 Jan 2005 22:49:44 +0100,
> > Stefan Macher wrote:
> > > 
> > > Hi,
> > > 
> > > I have made a patch to get SPDIF input working with the Realtek ALC658. 
> > > Realtek has changed the meaning of the Pin47 function selection bit (MX7A bit 
> > > 1 ) between ALC655 and ALC658.
> > > 
> > > ALC655: 0 -> external amplifier power down; 1 -> SPDIF IN
> > > ALC658: 0 -> SPDIF IN; 1 -> external amplifier power down
> > > 
> > > 
> > > Can please anybody include this into CVS.
> > 
> > The patch looks fine.
> > 
> > Could you provide a signed-off-by line and a brief summary of your
> > patch to put as a changelog?  The best would be like:
> > 
> > 	Summary: Fix blah
> > 
> > 	The patch fixes the problem of the driver xxx...
> > 
> > 	Signed-off-by: Foo Bar <foo@bar.com>
> > 
> > 
> > We need (prefer) to have this for each patch from contributors,
> > especially for the changes to alsa-kernel tree, which will appear
> > eventually in the Linux kernel tree.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> 
> Summary: Adapt SPDIF Input selection for Realtek ALC658
> 
> This fixes the SPDIF Input selection for ALC658 as Realtek has changed the meaning betweenALC655 and ALC658. 
> 
> Signed-off-by: Stefan Macher <Stefan.Macher@web.de>

Thanks, I applied now your patch to CVS.

(BTW, your mailer breaks the patch by converting tabs with spaces.
 Please use attachment at the next time).


Takashi


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt