From: Takashi Iwai <tiwai@suse.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org,
viro@parcelfarce.linux.theplanet.co.uk, perex@suse.cz,
torvalds@osdl.org
Subject: Re: [RFC] ASLA design, depth of code review and lack thereof
Date: Mon, 07 Jun 2004 16:12:54 +0200 [thread overview]
Message-ID: <s5h65a34ftl.wl@alsa2.suse.de> (raw)
In-Reply-To: <40C47635.4090302@pobox.com>
At Mon, 07 Jun 2004 10:05:41 -0400,
Jeff Garzik wrote:
>
> Takashi Iwai wrote:
> > They're nice but they don't provide "cast checking", no?
> > The main purpose of the magic_* stuffs in ALSA is to check the cast of
> > the void pointer back to the original data type, which the compiler
> > can't check.
>
> Sure -- and that magic cast stuff is horribly bloated, and not needed in
> good code.
A good code needs never debugging stuffs :)
I agree that the current ALSA's magic stuff is much bigger than
needed, though.
> No other code in Linux does this -- therefore it should be removed.
Hmm? The magic check itself is found in many linux driver codes...
Takashi
next prev parent reply other threads:[~2004-06-07 14:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-04 23:08 [RFC] ASLA design, depth of code review and lack thereof viro
2004-06-04 23:14 ` viro
2004-06-04 23:29 ` Linus Torvalds
2004-06-05 0:04 ` viro
2004-06-07 13:14 ` Takashi Iwai
2004-06-07 22:40 ` viro
2004-06-08 12:49 ` Takashi Iwai
2004-06-07 13:10 ` Takashi Iwai
2004-06-04 23:37 ` Jeff Garzik
2004-06-07 13:24 ` Takashi Iwai
2004-06-07 13:47 ` Jeff Garzik
2004-06-07 13:57 ` Takashi Iwai
2004-06-07 14:05 ` Jeff Garzik
2004-06-07 14:12 ` Takashi Iwai [this message]
2004-06-07 14:18 ` Russell King
2004-06-08 13:27 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h65a34ftl.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.