From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Date: Tue, 25 Jul 2017 17:42:59 +0200 Message-ID: References: <20170725151030.26863-1-sebastian.reichel@collabora.co.uk> <20170725151030.26863-2-sebastian.reichel@collabora.co.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id C4D11266CFE for ; Tue, 25 Jul 2017 17:43:00 +0200 (CEST) In-Reply-To: <20170725151030.26863-2-sebastian.reichel@collabora.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Sebastian Reichel Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, Tony Lindgren , linux-kernel@vger.kernel.org, Liam Girdwood , Rob Herring , Sebastian Reichel , Mark Brown List-Id: alsa-devel@alsa-project.org On Tue, 25 Jul 2017 17:10:25 +0200, Sebastian Reichel wrote: > > From: Tony Lindgren > > Some codecs may need to use this from loadable modules. Without > this patch compilation for this kind of codec will fail with the > following error: > > ERROR: "soc_dpcm_runtime_update" [sound/soc/codecs/snd-soc-cpcap.ko] > undefined! > > Signed-off-by: Tony Lindgren > Signed-off-by: Sebastian Reichel If you do export the function, please make its comments prettier, so that it appears in kernel documentation properly as an API function. Also, in general, we use snd_ prefix for the exported stuff. You'd need to rename it accordingly, too. Last but not least, this is specific to ASoC, so use "ASoC" prefix to the subject line. thanks, Takashi > --- > sound/soc/soc-pcm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c > index dcc5ece08668..4de7d86ea6fb 100644 > --- a/sound/soc/soc-pcm.c > +++ b/sound/soc/soc-pcm.c > @@ -2539,6 +2539,8 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card) > mutex_unlock(&card->mutex); > return 0; > } > +EXPORT_SYMBOL_GPL(soc_dpcm_runtime_update); > + > int soc_dpcm_be_digital_mute(struct snd_soc_pcm_runtime *fe, int mute) > { > struct snd_soc_dpcm *dpcm; > -- > 2.13.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbdGYPnD (ORCPT ); Tue, 25 Jul 2017 11:43:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:42438 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752505AbdGYPnB (ORCPT ); Tue, 25 Jul 2017 11:43:01 -0400 Date: Tue, 25 Jul 2017 17:42:59 +0200 Message-ID: From: Takashi Iwai To: "Sebastian Reichel" Cc: "Tony Lindgren" , "Liam Girdwood" , "Mark Brown" , "Rob Herring" , "Sebastian Reichel" , , "Jaroslav Kysela" , , , Subject: Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update In-Reply-To: <20170725151030.26863-2-sebastian.reichel@collabora.co.uk> References: <20170725151030.26863-1-sebastian.reichel@collabora.co.uk> <20170725151030.26863-2-sebastian.reichel@collabora.co.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jul 2017 17:10:25 +0200, Sebastian Reichel wrote: > > From: Tony Lindgren > > Some codecs may need to use this from loadable modules. Without > this patch compilation for this kind of codec will fail with the > following error: > > ERROR: "soc_dpcm_runtime_update" [sound/soc/codecs/snd-soc-cpcap.ko] > undefined! > > Signed-off-by: Tony Lindgren > Signed-off-by: Sebastian Reichel If you do export the function, please make its comments prettier, so that it appears in kernel documentation properly as an API function. Also, in general, we use snd_ prefix for the exported stuff. You'd need to rename it accordingly, too. Last but not least, this is specific to ASoC, so use "ASoC" prefix to the subject line. thanks, Takashi > --- > sound/soc/soc-pcm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c > index dcc5ece08668..4de7d86ea6fb 100644 > --- a/sound/soc/soc-pcm.c > +++ b/sound/soc/soc-pcm.c > @@ -2539,6 +2539,8 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card) > mutex_unlock(&card->mutex); > return 0; > } > +EXPORT_SYMBOL_GPL(soc_dpcm_runtime_update); > + > int soc_dpcm_be_digital_mute(struct snd_soc_pcm_runtime *fe, int mute) > { > struct snd_soc_dpcm *dpcm; > -- > 2.13.2 > >