From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 2/4] ALSA: hda - add DP mst verb support
Date: Mon, 07 Mar 2016 17:45:38 +0100
Message-ID: <s5h7fhedyod.wl-tiwai@suse.de>
References: <1457362666-53937-1-git-send-email-libin.yang@linux.intel.com>
 <1457362666-53937-3-git-send-email-libin.yang@linux.intel.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id D0F9A26145A
 for <alsa-devel@alsa-project.org>; Mon,  7 Mar 2016 17:45:38 +0100 (CET)
In-Reply-To: <1457362666-53937-3-git-send-email-libin.yang@linux.intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: libin.yang@linux.intel.com
Cc: libin.yang@intel.com, mengdong.lin@intel.com, alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

On Mon, 07 Mar 2016 15:57:44 +0100,
libin.yang@linux.intel.com wrote:
> 
> +int snd_hda_set_dev_select(struct hda_codec *codec, hda_nid_t nid, int dev_id)
> +{
> +	int ret, dev;
> +	unsigned long timeout;
> +
> +	/* not support dp_mst will always return 0, using first dev_entry */
> +	if (!codec->dp_mst)
> +		return 0;
> +
> +	/* If Device List Length is 0, the pin is not multi stream capable.
> +	 */
> +	if ((snd_hda_get_num_devices(codec, nid) + 1) == 0)
> +		return 0;

I don't understand what this code is for.  Why +1?

> +
> +	/* Behavior of setting index being equal to or greater than
> +	 * Device List Length is not predictable
> +	 */
> +	if ((snd_hda_get_num_devices(codec, nid) + 1) <= dev_id)
> +		return 0;

Ditto.  And, calling the same function twice?


thanks,

Takashi