From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: RFC: minimalistic TLV implementation
Date: Thu, 01 Jun 2006 17:40:27 +0200
Message-ID: <s5h7j407ul0.wl%tiwai@suse.de>
References: <Pine.LNX.4.61.0605311500480.9226@tm8103.perex-int.cz>
	<s5hzmgx6rtb.wl%tiwai@suse.de>
	<Pine.LNX.4.61.0606011510010.9144@tm8103.perex-int.cz>
	<s5hpsht6lo6.wl%tiwai@suse.de>
	<Pine.LNX.4.61.0606011602020.9144@tm8103.perex-int.cz>
	<s5hirnl6isc.wl%tiwai@suse.de>
	<Pine.LNX.4.61.0606011645530.9144@tm8103.perex-int.cz>
	<s5hejy87vu4.wl%tiwai@suse.de>
	<Pine.LNX.4.61.0606011715050.9144@tm8103.perex-int.cz>
	<s5hd5ds7vm6.wl%tiwai@suse.de>
	<Pine.LNX.4.61.0606011726051.9144@tm8103.perex-int.cz>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@lists.sourceforge.net>
Received: from mx1.suse.de (ns1.suse.de [195.135.220.2])
	by alsa.jcu.cz (ALSA's E-mail Delivery System) with ESMTP id E34BCF9
	for <alsa-devel@alsa-project.org>;
	Thu,  1 Jun 2006 17:40:27 +0200 (MEST)
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.suse.de (Postfix) with ESMTP id A95EFEF36
	for <alsa-devel@alsa-project.org>;
	Thu,  1 Jun 2006 17:40:27 +0200 (CEST)
In-Reply-To: <Pine.LNX.4.61.0606011726051.9144@tm8103.perex-int.cz>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: alsa-devel-bounces@lists.sourceforge.net
Errors-To: alsa-devel-bounces@lists.sourceforge.net
To: Jaroslav Kysela <perex@suse.cz>
Cc: ALSA development <alsa-devel@alsa-project.org>
List-Id: alsa-devel@alsa-project.org

At Thu, 1 Jun 2006 17:28:41 +0200 (CEST),
Jaroslav Kysela wrote:
> 
> diff -r 96e63842ba5d include/asound.h
> --- a/include/asound.h	Wed May 31 11:55:17 2006 +0200
> +++ b/include/asound.h	Thu Jun  1 17:25:38 2006 +0200
> @@ -688,7 +688,7 @@ struct snd_timer_tread {
>   *                                                                          *
>   ****************************************************************************/
>  
> -#define SNDRV_CTL_VERSION		SNDRV_PROTOCOL_VERSION(2, 0, 3)
> +#define SNDRV_CTL_VERSION		SNDRV_PROTOCOL_VERSION(2, 0, 4)
>  
>  struct snd_ctl_card_info {
>  	int card;			/* card number */
> @@ -818,6 +818,20 @@ struct snd_ctl_elem_value {
>          unsigned char reserved[128-sizeof(struct timespec)];
>  };
>  
> +struct snd_ctl_tlv {
> +        unsigned int numid;	/* control element numeric identification */
> +        unsigned int length;	/* in bytes aligned to 4 */
> +        /*
> +         * TLV structure is right behind the struct snd_ctl_tlv:
> +         *   unsigned int type	- see SNDRV_CTL_TLVT_*
> +         *   unsigned int length
> +         *   .... data aligned to sizeof(unsigned int), use
> +         *        block_length = (length + (sizeof(unsigned int) - 1)) &
> +         *                       ~(sizeof(unsigned int) - 1)) ....
> +         */

I'd put this detailed comment in tlv.h, and here shows a short comment
like:
"TLV data is put right behind the struct snd_ctl_tlv.
 See tlv.h for definition of TLV data".


Takashi