Re: sequencer module problems

[Takashi Iwai <tiwai@suse.de>]

At Wed, 19 Mar 2003 12:45:16 +0200,
Andrei Boros wrote:
> 
> First of all, my make is 3.77 and lacks support for the  $(if
> CONDITION,THEN-PART[,ELSE-PART])
> function. So I tried to replace it by some sort of equivalent selected
> by existing conditionals. 
> 
> As make does not support the syntax below, it ignore it. 
> 
> in alsa-driver/alsa-kernel/core/seq:
> #
> # this function returns:
> #   "m" - CONFIG_SND_SEQUENCER is m
> #   <empty string> - CONFIG_SND_SEQUENCER is undefined
> #   otherwise parameter #1 value
> #
> 
> sequencer = $(if $(subst y,,$(CONFIG_SND_SEQUENCER)),$(if $(1),m),$(if
> $(CONFIG_SND_SEQUENCER),$(1)))
> 
> 
> After reading some docs, I understand the following:
> CONFIG_SND_SEQUENCER=m (actually set to anything but "y") -> if $(1) is
> defined -> sequencer=m
> CONFIG_SND_SEQUENCER=y -> sequencer=$(1), since the subsequent test will
> always see it defined.
> CONFIG_SND_SEQUENCER undefined -> sequencer = 
> 
> 
> I checked the configure script and CONFIG_SND_SEQUENCER is set to "m" if
> --with-sequencer=yes or is left undefined otherwise. So any other value
> for CONFIG_SND_SEQUENCER is not possible. 
> 
> I checked that Makefile again and I see that all calls to the function
> sequencer add $(RAWMIDI_OBJS), only some add $(OPL3_OBJS) and some add
> individual modules. 
> 
> Then I believe the following could be done:
> 
> -obj-$(CONFIG_SND_SEQUENCER) += snd-seq.o snd-seq-device.o
> +obj-$(CONFIG_SND_SEQUENCER) += snd-seq.o snd-seq-device.o
> $(RAWMIDI_OBJS)
> 
> Then, 
> 
> # Toplevel Module Dependency
> obj-$(CONFIG_SND_VIRMIDI) += snd-seq-virmidi.o snd-seq-midi-event.o
> ifeq ($(CONFIG_SND_SEQUENCER),m)
> obj-$($(CONFIG_SND_SERIAL_U16550)) +=
> obj-$($(CONFIG_SND_MTPAV)) += 
> obj-$($(CONFIG_SND_MPU401)) += 
> obj-$($(CONFIG_SND_ALS100)) += $(OPL3_OBJS)
> obj-$($(CONFIG_SND_AZT2320)) += $(OPL3_OBJS)
> obj-$($(CONFIG_SND_DT019X)) += $(OPL3_OBJS)
> [snip]
> obj-$($(CONFIG_SND_CS46XX)) += 
> obj-$($(CONFIG_SND_EMU10K1)) += snd-seq-midi-emul.o snd-seq-virmidi.o
> obj-$($(CONFIG_SND_TRIDENT)) += snd-seq-midi-emul.o snd-seq-instr.o
> obj-$($(CONFIG_SND_YMFPCI)) += $(OPL3_OBJS)
> obj-$($(CONFIG_SND_USB_AUDIO)) += 
> obj-$($(CONFIG_SND_HDSP)) += 
> endif
> 
> obj-m := $(sort $(obj-m))
> 
> Then, the sequencer function above is no longer needed.

well, some points noted.

1. CONFIG_SND_SEQUENCER is set to m only in the alsa-driver configure
   because alsa-driver package provides only the modules.
   you change above doesn't handle the case for built-in drivers.

2. rawmidi is not used in every system.  this should belong to
   the card dependent defines.

3. the use of sequencer macro is intended for removal of if condition
   in the definitions of modules.  so, going back to the style shown
   above is not acceptable for 2.5 kernel tree.
   (2.5 kernel tree needs anyway the newer verision of make which can
    handle the macro correctly.)


a workaround would be to rewrite the Makefile in alsa-driver/core/seq
without reading the alsa-kernel Makefile.
but from the maintenace perspective, it's also not nice...


ciao,

Takashi


-------------------------------------------------------
This SF.net email is sponsored by: Does your code think in ink? 
You could win a Tablet PC. Get a free Tablet PC hat just for playing. 
What are you waiting for?
http://ads.sourceforge.net/cgi-bin/redirect.pl?micr5043en