All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Osamu Tomita <tomita@cinet.co.jp>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa)
Date: Fri, 01 Nov 2002 14:44:25 +0100	[thread overview]
Message-ID: <s5h7kfxs8ue.wl@alsa2.suse.de> (raw)
In-Reply-To: <20021101220218.A12315@precia.cinet.co.jp>

At Fri, 1 Nov 2002 22:02:18 +0900,
Osamu Tomita wrote:
> 
> 2002.10.31 02:52, Takashi Iwai wrote:
> > At Wed, 30 Oct 2002 02:43:22 +0900,
> (snip)
> > do you mean that the interrupts are generated too slowly?
> > you can measure how many UART interrupts are generated per second by
> > checking /proc/interrupts.
> > if it's too little, the problem is likely in the hardware
> > initialization part, which i simply copied from your patch.
> > but it could be a wrong copy & paste.
> > please check pc98_mpu401_init() in pc98.c.
> > 
> > btw, which MPU mode are you using, PC98II or normal MPU401?
> Thanks! Problem solved. MPU401 works fine by trivial fix as follows.
> 
> #--- linux/sound/isa/cs423x/pc98.c.old	Wed Oct 30 00:20:35 2002
> #+++ linux/sound/isa/cs423x/pc98.c	Fri Nov  1 20:45:31 2002
> #@@ -379,7 +379,7 @@
> # 		err = pc98_mpu401_init(mpu_irq[dev]);
> # 		if (! err) {
> # 			err = snd_mpu401_uart_new(card, 0,
> #-						  pc98ii ? 
> MPU401_HW_PC98II : MPU401_HW_MPU401,
> #+						  pc98ii[dev] ? 
> MPU401_HW_PC98II : MPU401_HW_MPU401,
> # 						  mpu_port[dev], 0,
> # 						  mpu_irq[dev], 
> SA_INTERRUPT, NULL);
> # 			if (err < 0)

d'oh.  thanks.

> 
> Now, PCM OPL3 and MPU401 all works fine.
> Would you please add option "pc98ii" into snd-mpu401?
> This is for Box that has MPU-PC98II only, with no other sound card.

well, then i misunderstood the hardware configuration on PC98.

doesn't MPU-PC98II need any specific hardware init code like in
pc98_mpu401_init()?

if yes, then we should create another module for PC98II rather than
including a magical init code into a generic mpu401 module.


ciao,

Takashi

  reply	other threads:[~2002-11-01 13:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-26  2:54 [PATCHSET 22/25] add support for PC-9800 architecture (sound alsa) Osamu Tomita
2002-10-28 17:57 ` Takashi Iwai
2002-10-29 10:08   ` Takashi Iwai
2002-10-29 17:43     ` Osamu Tomita
2002-10-30 17:52       ` Takashi Iwai
2002-11-01 13:02         ` Osamu Tomita
2002-11-01 13:44           ` Takashi Iwai [this message]
2002-11-02  2:44             ` Osamu Tomita
2002-11-04 10:17               ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2002-10-25  2:47 Osamu Tomita
2002-10-25 10:10 ` Takashi Iwai
2002-10-25  2:12 Osamu Tomita
2002-10-18 16:56 Osamu Tomita
2002-10-23 11:01 ` Takashi Iwai
2002-10-23 15:35   ` Osamu Tomita
2002-10-23 15:46     ` Takashi Iwai
2002-10-23 16:12       ` Osamu Tomita
2002-10-23 16:29       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h7kfxs8ue.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomita@cinet.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.