From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] snd/hda: Only get/put display_power once Date: Wed, 10 Apr 2019 13:03:22 +0200 Message-ID: References: <20190410081733.22271-1-chris@chris-wilson.co.uk> <155489186442.3516.8140753892842277081@skylake-alporthouse-com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 05CB589415 for ; Wed, 10 Apr 2019 11:03:25 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxMCBBcHIgMjAxOSAxMjo0NDo0OSArMDIwMCwKVGFrYXNoaSBJd2FpIHdyb3RlOgo+ IAo+IE9uIFdlZCwgMTAgQXByIDIwMTkgMTI6MjQ6MjQgKzAyMDAsCj4gQ2hyaXMgV2lsc29uIHdy b3RlOgo+ID4gCj4gPiBRdW90aW5nIFRha2FzaGkgSXdhaSAoMjAxOS0wNC0xMCAxMTowOTo0NykK PiA+ID4gT24gV2VkLCAxMCBBcHIgMjAxOSAxMDoxNzozMyArMDIwMCwKPiA+ID4gQ2hyaXMgV2ls c29uIHdyb3RlOgo+ID4gPiA+IAo+ID4gPiA+IFdoaWxlIHdlIG9ubHkgYWxsb3cgYSBzaW5nbGUg ZGlzcGxheSBwb3dlciByZWZlcmVuY2UsIHRoZSBjdXJyZW50Cj4gPiA+ID4gYWNxdWlzaXRpb24v cmVsZWFzZSBpcyByYWN5IGFuZCBhIGRpcmVjdCBjYWxsIG1heSBydW4gY29uY3VycmVudGx5IHdp dGgKPiA+ID4gPiBhIHJ1bnRpbWUtcG0gd29ya2VyLiBQcmV2ZW50IHRoZSBkb3VibGUgdW5yZWZl cmVuY2UgYnkgYXRvbWljYWxseQo+ID4gPiA+IHRyYWNraW5nIHRoZSBkaXNwbGF5X3Bvd2VyX2Fj dGl2ZSBjb29raWUuCj4gPiA+ID4gCj4gPiA+ID4gVGVzdGNhc2U6IGlndC9pOTE1X3BtX3JwbS9t b2R1bGUtcmVsb2FkICNnbGstZHNpCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiA+ID4gQ2M6IFRha2FzaGkgSXdhaSA8dGl3 YWlAc3VzZS5kZT4KPiA+ID4gPiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ ID4gPiAKPiA+ID4gSSByYXRoZXIgcHJlZmVyIGEgbW9yZSBzdHJhaWdodGZvcndhcmQgY29udmVy c2lvbiwgZS5nLiBzb21ldGhpbmcgbGlrZQo+ID4gPiBiZWxvdy4gIENoZWNraW5nIHRoZSByZXR1 cm5lZCBjb29raWUgYXMgdGhlIHN0YXRlIGZsYWcgaXMgbm90IHF1aXRlCj4gPiA+IGludHVpdGl2 ZSwgc28gcmV2aXZlIHRoZSBib29sZWFuIHN0YXRlIGZsYWcsIGFuZCBoYW5kbGUgaXQKPiA+ID4g YXRvbWljYWxseS4KPiA+IAo+ID4gQWNjZXNzIHRvIHRoZSBjb29raWUgaXRzZWxmIGlzIG5vdCBh dG9taWMgdGhlcmUsIGFuZCB0aGVvcmV0aWNhbGx5Cj4gPiB0aGVyZSBjb3VsZCBiZSBhIGdldC9w dXQvZ2V0IHJ1bm5pbmcgY29uY3VycmVudGx5LiBBcmUgeW91IHN1cmUgZG9uJ3QKPiA+IHdhbnQg YSByZWZjb3VudCBhbmQgbG9jayBoZXJlPyA6KQo+IAo+IFRoZSByZWZjb3VudCBpcyB3aGF0IHdl IHdhbnQgdG8gcmVkdWNlLCBzbyB0aGUgc3VpdGFibGUgb3B0aW9uIHdvdWxkCj4gYmUgYSAoeWV0 IGFub3RoZXIpIG11dGV4IGFsdGhvdWdoIHRoZSBjbXB4Y2hnKCkgc2hvdWxkIGJlIGVub3VnaCBm b3IKPiBub3JtYWwgY2FzZXMuCj4gCj4gPiBZb3VyIGNhbGwuIEZvciB0aGUgY2FzZSBDSSBpcyBo aXR0aW5nLCBpdCBzaG91bGQgZG8gdGhlIHRyaWNrIChhcyB3ZSBhcmUKPiA+IG9ubHkgc2VlaW5n IHRoZSByYWNlIG9uIHB1dC9wdXQgSSB0aGluaykuIENJIHdpbGwgYW5zd2VyIGluIGEgaG91ciBv cgo+ID4gdHdvLgo+IAo+IE9LLCBvbmNlIHdoZW4gaXQgc2VlbXMgd29ya2luZywgSSdsbCByZXNw aW4gYSBwYXRjaCB3aXRoIGEgbXV0ZXgKPiBpbnN0ZWFkLiAgV2UgaGF2ZSBhbHJlYWR5IGEgb25l IHRoYXQgaXMgdXNlZCBmb3IgdGhlIGxpbmsgc3RhdGUKPiBjaGFuZ2UsIGFuZCB0aGlzIGNhbiBi ZSByZXVzZWQuCgpJdCdzIGV2ZW4gc2ltcGxlciwgc28gbWF5YmUgdGhpcyBpcyBhIGJldHRlciB3 YXkgdG8gZ28uLi4KCklmIHRoaXMgaXMgY29uZmlybWVkIHRvIHdvcmssIGZlZWwgZnJlZSB0byBx dWV1ZSB2aWEgZHJtIHRyZWUuCkkgY2FuJ3QgYXBwbHkgdGhpcyBiZWNhdXNlIHRoaXMgaXMgb24g dG9wIG9mIHlvdXIgcmVjZW50IGNvb2tpZSBhbmQKc3ViLWNvbXBvbmVudCBjaGFuZ2VzIHRoYXQg YXJlbid0IG9uIHNvdW5kIGdpdCB0cmVlICh5ZXQpLgoKCnRoYW5rcywKClRha2FzaGkKCi0tIDg8 IC0tCkZyb206IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5kZT4KU3ViamVjdDogW1BBVENIXSBB TFNBOiBoZGE6IEZpeCByYWN5IGRpc3BsYXkgcG93ZXIgYWNjZXNzCgpzbmRfaGRhY19kaXNwbGF5 X3Bvd2VyKCkgZG9lc24ndCBoYW5kbGUgdGhlIGNvbmN1cnJlbnQgY2FsbHMgY2FyZWZ1bGx5CmVu b3VnaCwgYW5kIGl0IG1heSBsZWFkIHRvIHRoZSBkb3VibHkgZ2V0X3Bvd2VyIG9yIHB1dF9wb3dl ciBjYWxscywKd2hlbiBhIHJ1bnRpbWUgUE0gYW5kIGFuIGFzeW5jIHdvcmsgZ2V0IGNhbGxlZCBp biByYWN5IHdheS4KClRoaXMgcGF0Y2ggYWRkcmVzc2VzIGl0IGJ5IHJldXNpbmcgdGhlIGJ1cy0+ bG9jayBtdXRleCB0aGF0IGhhcyBiZWVuCnVzZWQgZm9yIHByb3RlY3RpbmcgdGhlIGxpbmsgc3Rh dGUgY2hhbmdlIGluIGV4dCBidXMgY29kZSwgc28gdGhhdCBpdApjYW4gcHJvdGVjdCBhZ2FpbnN0 IHJhY3kgZGlzcGxheSBzdGF0ZSBjaGFuZ2VzLiAgVGhlIGluaXRpYWxpemF0aW9uIG9mCmJ1cy0+ bG9jayB3YXMgbW92ZWQgZnJvbSBzbmRfaGRhY19leHRfYnVzX2luaXQoKSB0bwpzbmRfaGRhY19i dXNfaW5pdCgpIGFzIHdlbGwgYWNjb3JkaW5nbHkuCgpUZXN0Y2FzZTogaWd0L2k5MTVfcG1fcnBt L21vZHVsZS1yZWxvYWQgI2dsay1kc2kKUmVwb3J0ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNA Y2hyaXMtd2lsc29uLmNvLnVrPgpDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgpT aWduZWQtb2ZmLWJ5OiBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuZGU+Ci0tLQogc291bmQvaGRh L2V4dC9oZGFjX2V4dF9idXMuYyB8IDEgLQogc291bmQvaGRhL2hkYWNfYnVzLmMgICAgICAgICB8 IDEgKwogc291bmQvaGRhL2hkYWNfY29tcG9uZW50LmMgICB8IDYgKysrKystCiAzIGZpbGVzIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zb3Vu ZC9oZGEvZXh0L2hkYWNfZXh0X2J1cy5jIGIvc291bmQvaGRhL2V4dC9oZGFjX2V4dF9idXMuYwpp bmRleCA5YzM3ZDlhZjMwMjMuLmVjNzcxNWM2YjBjMCAxMDA2NDQKLS0tIGEvc291bmQvaGRhL2V4 dC9oZGFjX2V4dF9idXMuYworKysgYi9zb3VuZC9oZGEvZXh0L2hkYWNfZXh0X2J1cy5jCkBAIC0x MDcsNyArMTA3LDYgQEAgaW50IHNuZF9oZGFjX2V4dF9idXNfaW5pdChzdHJ1Y3QgaGRhY19idXMg KmJ1cywgc3RydWN0IGRldmljZSAqZGV2LAogCUlOSVRfTElTVF9IRUFEKCZidXMtPmhsaW5rX2xp c3QpOwogCWJ1cy0+aWR4ID0gaWR4Kys7CiAKLQltdXRleF9pbml0KCZidXMtPmxvY2spOwogCWJ1 cy0+Y21kX2RtYV9zdGF0ZSA9IHRydWU7CiAKIAlyZXR1cm4gMDsKZGlmZiAtLWdpdCBhL3NvdW5k L2hkYS9oZGFjX2J1cy5jIGIvc291bmQvaGRhL2hkYWNfYnVzLmMKaW5kZXggMDEyMzA1MTc3ZjY4 Li5hZDhlZWUwODAxM2YgMTAwNjQ0Ci0tLSBhL3NvdW5kL2hkYS9oZGFjX2J1cy5jCisrKyBiL3Nv dW5kL2hkYS9oZGFjX2J1cy5jCkBAIC0zOCw2ICszOCw3IEBAIGludCBzbmRfaGRhY19idXNfaW5p dChzdHJ1Y3QgaGRhY19idXMgKmJ1cywgc3RydWN0IGRldmljZSAqZGV2LAogCUlOSVRfV09SSygm YnVzLT51bnNvbF93b3JrLCBzbmRfaGRhY19idXNfcHJvY2Vzc191bnNvbF9ldmVudHMpOwogCXNw aW5fbG9ja19pbml0KCZidXMtPnJlZ19sb2NrKTsKIAltdXRleF9pbml0KCZidXMtPmNtZF9tdXRl eCk7CisJbXV0ZXhfaW5pdCgmYnVzLT5sb2NrKTsKIAlidXMtPmlycSA9IC0xOwogCXJldHVybiAw OwogfQpkaWZmIC0tZ2l0IGEvc291bmQvaGRhL2hkYWNfY29tcG9uZW50LmMgYi9zb3VuZC9oZGEv aGRhY19jb21wb25lbnQuYwppbmRleCAxMzkxNWZkYzZhNTQuLmRmZTdlNzU1ZjU5NCAxMDA2NDQK LS0tIGEvc291bmQvaGRhL2hkYWNfY29tcG9uZW50LmMKKysrIGIvc291bmQvaGRhL2hkYWNfY29t cG9uZW50LmMKQEAgLTY5LDEzICs2OSwxNSBAQCB2b2lkIHNuZF9oZGFjX2Rpc3BsYXlfcG93ZXIo c3RydWN0IGhkYWNfYnVzICpidXMsIHVuc2lnbmVkIGludCBpZHgsIGJvb2wgZW5hYmxlKQogCiAJ ZGV2X2RiZyhidXMtPmRldiwgImRpc3BsYXkgcG93ZXIgJXNcbiIsCiAJCWVuYWJsZSA/ICJlbmFi bGUiIDogImRpc2FibGUiKTsKKworCW11dGV4X2xvY2soJmJ1cy0+bG9jayk7CiAJaWYgKGVuYWJs ZSkKIAkJc2V0X2JpdChpZHgsICZidXMtPmRpc3BsYXlfcG93ZXJfc3RhdHVzKTsKIAllbHNlCiAJ CWNsZWFyX2JpdChpZHgsICZidXMtPmRpc3BsYXlfcG93ZXJfc3RhdHVzKTsKIAogCWlmICghYWNv bXAgfHwgIWFjb21wLT5vcHMpCi0JCXJldHVybjsKKwkJZ290byB1bmxvY2s7CiAKIAlpZiAoYnVz LT5kaXNwbGF5X3Bvd2VyX3N0YXR1cykgewogCQlpZiAoIWJ1cy0+ZGlzcGxheV9wb3dlcl9hY3Rp dmUpIHsKQEAgLTk4LDYgKzEwMCw4IEBAIHZvaWQgc25kX2hkYWNfZGlzcGxheV9wb3dlcihzdHJ1 Y3QgaGRhY19idXMgKmJ1cywgdW5zaWduZWQgaW50IGlkeCwgYm9vbCBlbmFibGUpCiAJCQlidXMt PmRpc3BsYXlfcG93ZXJfYWN0aXZlID0gMDsKIAkJfQogCX0KKyB1bmxvY2s6CisJbXV0ZXhfdW5s b2NrKCZidXMtPmxvY2spOwogfQogRVhQT1JUX1NZTUJPTF9HUEwoc25kX2hkYWNfZGlzcGxheV9w b3dlcik7CiAKLS0gCjIuMTYuNAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4