From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH - hda 1/1] ALSA: hda - Add PCI quirk for 17" MacBook Pro 5, 2 model (July 2009) to use existing mb5 model Date: Thu, 21 Jan 2010 12:56:38 +0100 Message-ID: References: <4b583eaa.0d0bca0a.753e.37fc@mx.google.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 69942243A6 for ; Thu, 21 Jan 2010 12:56:39 +0100 (CET) In-Reply-To: <4b583eaa.0d0bca0a.753e.37fc@mx.google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: murray.alex@gmail.com Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 21 Jan 2010 22:16:26 +1030, murray.alex@gmail.com wrote: > > From: Alex Murray > > > Signed-off-by: Alex Murray > --- > pci/hda/patch_realtek.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/pci/hda/patch_realtek.c b/pci/hda/patch_realtek.c > index 7e0ea37..d044db9 100644 > --- a/pci/hda/patch_realtek.c > +++ b/pci/hda/patch_realtek.c > @@ -9223,6 +9223,7 @@ static struct snd_pci_quirk alc882_ssid_cfg_tbl[] = { > */ > SND_PCI_QUIRK(0x106b, 0x4000, "MacbookPro 5,1", ALC885_MB5), > SND_PCI_QUIRK(0x106b, 0x4600, "MacbookPro 5,2", ALC885_MB5), > + SND_PCI_QUIRK(0x10ec, 0x0885, "MacbookPro 5,2", ALC885_MB5), Thanks for the patch. But I wonder whether this entry is really correct. The value looks like the codec vendor id. There you need a PCI SSID. Did you confirm that your patch really works? Takashi