From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Unhelpful permissions in some /proc files Date: Tue, 12 Apr 2005 17:34:33 +0200 Message-ID: References: <424DBAE9.7060208@yahoo.fr> <4251320C.2040503@yahoo.fr> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <4251320C.2040503@yahoo.fr> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Guillaume Chazarain Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Mon, 04 Apr 2005 14:24:44 +0200, Guillaume Chazarain wrote: > > Takashi Iwai wrote: > > >BTW, instead of patching each part, checking S_IWUSR in > >snd_info_register() may an easier solution. The patch is below. > > > > > Yes, of course, but I didn't like the fact that it looked like a fix > done by the callee. > Either snd_info_register() is passed good permissions and it doesn't > change them, > or its job to set them, then they should not be set before. > > The comment in your patch explained exactly what I felt, but anyway, if > you like > it that way, it's fine for me too. Sorry for the late response. I forgot this one. Well, since the changes are not in many places anyway, I just added the permission in each place as you did. Now it's fixed on CVS. Thanks, Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click