Re: Unhelpful permissions in some /proc files

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

At Fri, 01 Apr 2005 23:19:37 +0200,
Guillaume Chazarain wrote:
> 
> Hello,
> 
> Some tunables in /proc have a write() function, but as their
> permission does not reflect it, it can be confusing to the user.
> 
> So here is a patch that corrects the mode of those files. Note that I
> have only tested the "xrun_debug" entry.

Thanks for the patch.

> Also, there is a little inconsistency in that some code does
> 'entry->mode = S_IFREG | S_IRUGO | S_IWUSR;' whereas some other does
> 'entry->mode |= S_IWUSR;'.

I think the latter form is enough.

BTW, instead of patching each part, checking S_IWUSR in
snd_info_register() may an easier solution.  The patch is below.


Takashi

[-- Attachment #2: Type: text/plain, Size: 800 bytes --]

Index: alsa-kernel/core/info.c
===================================================================
RCS file: /home/iwai/cvs/alsa/alsa-kernel/core/info.c,v
retrieving revision 1.48
diff -u -r1.48 info.c
--- alsa-kernel/core/info.c	22 Mar 2005 15:18:27 -0000	1.48
+++ alsa-kernel/core/info.c	4 Apr 2005 10:31:14 -0000
@@ -910,6 +910,12 @@
 
 	snd_assert(entry != NULL, return -ENXIO);
 	root = entry->parent == NULL ? snd_proc_root : entry->parent->p;
+	if ((entry->content == SNDRV_INFO_CONTENT_TEXT && entry->c.text.write_size) ||
+	    (entry->content == SNDRV_INFO_CONTENT_DATA && entry->c.ops->write)) {
+		/* fix up write permission */
+		if (! (entry->mode & S_IWUGO))
+			entry->mode |= S_IWUSR;
+	}
 	down(&info_mutex);
 	p = snd_create_proc_entry(entry->name, entry->mode, root);
 	if (!p) {