From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: Click after draining
Date: Wed, 20 Oct 2004 11:38:39 +0200
Sender: alsa-devel-admin@lists.sourceforge.net
Message-ID: <s5h8ya1iva8.wl@alsa2.suse.de>
References: <s5hekjuiuom.wl@alsa2.suse.de>
	<XFMail.20041020103534.pochini@shiny.it>
Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
Return-path: <alsa-devel-admin@lists.sourceforge.net>
In-Reply-To: <XFMail.20041020103534.pochini@shiny.it>
Errors-To: alsa-devel-admin@lists.sourceforge.net
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
To: Giuliano Pochini <pochini@shiny.it>
Cc: alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

At Wed, 20 Oct 2004 10:35:34 +0200 (CEST),
Giuliano Pochini wrote:
> 
> >> Anyway, _fill_silence() can still overflow.
> >
> > In your case, yes.  But it's exceptional.
> 
> No, it also happens with you example when
> period_offs+period_len > buffer_size:
> 
> N=3.5:
> 
> first round:
> 0000000011111111222222223333
> 
> 2nd:
> 3333444444445555555566666666
> ....
> 
> fill_silence(per=3, period_len) overflows.

Oh, yeah, you're right.  This has to be handled correctly in
fill_silence().


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl