From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58E32C433F5 for ; Mon, 28 Feb 2022 16:03:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7F53017F2; Mon, 28 Feb 2022 17:03:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7F53017F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646064232; bh=G+PLDWq/eXUdY4L5ZnTPVK4l7tpAXq7IE5tod0zBxJ4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bCNgHKZ9w1qeOOAlinqxv/G+zmDAQfihFBp8NFN70+v0KLnPWIyTohcSi6KKkaBlr gsJez74bKDwA/WJP7eX4LU82UBwqFT8Dh7akkmfLmFkzY0hJ1Ct1Uifi76Oh8qeA/A dKjGHplQyCOFHHTJ4ogiMw3N0qzvSO1wQ9Ydd3sc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2A592F80128; Mon, 28 Feb 2022 17:03:02 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 04AAEF800F8; Mon, 28 Feb 2022 17:03:01 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 33635F800F8 for ; Mon, 28 Feb 2022 17:02:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 33635F800F8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="wX0tSG3G"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="0osxI8By" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 017D81F3A3; Mon, 28 Feb 2022 16:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646064175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wJaYb+JWizWqpLs2nbmXbz0b4Z0hIdwCg2krYTXjRlk=; b=wX0tSG3G7YSZtiWMHVSpB27s8jMykCuArN0nLk3O9hMIaosxk1NfX6VZd2Uij5e3lkxrAu 6lnzpZcbJClETo6vAa3/vyDtb9Ie8JNVdcc0vdwAP/PMpvrBo1m6mfOEjOPZEgNPrg58tH q++absDKmpVPh9umOucO1cRahczYWLs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646064175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wJaYb+JWizWqpLs2nbmXbz0b4Z0hIdwCg2krYTXjRlk=; b=0osxI8ByW+9/LQdubg7oPeyw4GvsAvB7YEZp3Xsci4FPr6Y6yP3+WBjsC/7nrR64lj8HVW LcOJKnOWhY51diAQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id D65D4A3B89; Mon, 28 Feb 2022 16:02:54 +0000 (UTC) Date: Mon, 28 Feb 2022 17:02:54 +0100 Message-ID: From: Takashi Iwai To: Joe Perches Subject: Re: [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement In-Reply-To: References: <20220228050253.1649-1-tangmeng@uniontech.com> <20220228050253.1649-2-tangmeng@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Meng Tang , alsa-devel@alsa-project.org, tiwai@suse.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 28 Feb 2022 06:20:45 +0100, Joe Perches wrote: > > On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote: > > Return the result from file->f_op->open() directly instead of > > taking this in another redundant variable. Make the typical > > return the last statement, return early and reduce the indentation > > too. > > > > Signed-off-by: Meng Tang > > Signed-off-by: Joe Perches > > Hi Meng Tang. > > For the next time: it's not necessary (or even good) to add a sign-off > for another person unless they specifically authorize one. > > You wrote and are submitting these changes, I merely gave you simple > suggestions as to how you could improve them. Joe, would you like to drop your S-o-b lines from those two patches? Or shall I keep them? thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8135DC433F5 for ; Mon, 28 Feb 2022 16:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234941AbiB1QDk (ORCPT ); Mon, 28 Feb 2022 11:03:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235353AbiB1QDf (ORCPT ); Mon, 28 Feb 2022 11:03:35 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41A2B3CFDE for ; Mon, 28 Feb 2022 08:02:56 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 017D81F3A3; Mon, 28 Feb 2022 16:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1646064175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wJaYb+JWizWqpLs2nbmXbz0b4Z0hIdwCg2krYTXjRlk=; b=wX0tSG3G7YSZtiWMHVSpB27s8jMykCuArN0nLk3O9hMIaosxk1NfX6VZd2Uij5e3lkxrAu 6lnzpZcbJClETo6vAa3/vyDtb9Ie8JNVdcc0vdwAP/PMpvrBo1m6mfOEjOPZEgNPrg58tH q++absDKmpVPh9umOucO1cRahczYWLs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1646064175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wJaYb+JWizWqpLs2nbmXbz0b4Z0hIdwCg2krYTXjRlk=; b=0osxI8ByW+9/LQdubg7oPeyw4GvsAvB7YEZp3Xsci4FPr6Y6yP3+WBjsC/7nrR64lj8HVW LcOJKnOWhY51diAQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id D65D4A3B89; Mon, 28 Feb 2022 16:02:54 +0000 (UTC) Date: Mon, 28 Feb 2022 17:02:54 +0100 Message-ID: From: Takashi Iwai To: Joe Perches Cc: Meng Tang , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] ALSA: core: Remove redundant variable and return the last statement In-Reply-To: References: <20220228050253.1649-1-tangmeng@uniontech.com> <20220228050253.1649-2-tangmeng@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Feb 2022 06:20:45 +0100, Joe Perches wrote: > > On Mon, 2022-02-28 at 13:02 +0800, Meng Tang wrote: > > Return the result from file->f_op->open() directly instead of > > taking this in another redundant variable. Make the typical > > return the last statement, return early and reduce the indentation > > too. > > > > Signed-off-by: Meng Tang > > Signed-off-by: Joe Perches > > Hi Meng Tang. > > For the next time: it's not necessary (or even good) to add a sign-off > for another person unless they specifically authorize one. > > You wrote and are submitting these changes, I merely gave you simple > suggestions as to how you could improve them. Joe, would you like to drop your S-o-b lines from those two patches? Or shall I keep them? thanks, Takashi