From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D4CC433EF for ; Fri, 1 Oct 2021 06:59:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8BB661A71 for ; Fri, 1 Oct 2021 06:59:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A8BB661A71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9CEC516CA; Fri, 1 Oct 2021 08:59:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9CEC516CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1633071591; bh=FNL5ZgHmXJ+mtsQ5WK2usu16zUwaSNCg20aHecdM6DE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=jUT73Q7o+G8GjsQOQ0fEXQHCkyASHVFhCR2Jv0Os4QYRg28y15G4+VCjT1dpNG/Ou oMm9uFcKecJojwUU5m2f1RMBXmopaCPFhaPCAkDsfsWq96k6ig15OKtxTR3u5tZYky 5XL9UVdE9usDQnUloR3LxsA2Mj+H0gl3gXzVqEAo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 21D7CF80227; Fri, 1 Oct 2021 08:59:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 186F0F801F7; Fri, 1 Oct 2021 08:58:59 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4432FF801F7 for ; Fri, 1 Oct 2021 08:58:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4432FF801F7 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="OAWUoKaU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="bf4B0aiD" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id DFF5C2041B; Fri, 1 Oct 2021 06:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1633071528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xrlei0qtygaPXhT3SGHUlKblp0USvkDO4i6z8JM3LX0=; b=OAWUoKaUe4EnnyEm9tRxA8lZfh82R6qyDG21zZbJMJeCOtD1vBiCOSGK6zOqYI60OytQXV Cmc5YS7Tb5lxmo/WJtWHC74Tl/wAj4w4IfIIBk0HoCvZV/+pa8UOUWqNYMIeSc5TOOnUWP If+IzoSiWkJ41Z1XgYDE8IQmJ0aAWyc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1633071528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xrlei0qtygaPXhT3SGHUlKblp0USvkDO4i6z8JM3LX0=; b=bf4B0aiDneMSPgTZ7lUbpegm6FSHhivxzsnmxGAImPQnvzCX/t1vKr+GKHU2kCPaeKTg8c pVlioiVs05LvWwAQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id D9A00A3B81; Fri, 1 Oct 2021 06:58:48 +0000 (UTC) Date: Fri, 01 Oct 2021 08:58:48 +0200 Message-ID: From: Takashi Iwai To: Geraldo Nascimento Subject: Re: [PATCH] ALSA: usb-audio: disable implicit feedback sync for Behringer UFX1204 and UFX1604 In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 30 Sep 2021 21:40:14 +0200, Geraldo Nascimento wrote: > > Hi Takashi, > > Hopefully you will be able to apply this cleanly to branch master of your > sound.git. > > Thanks! > Geraldo Nascimento > > --- > > Behringer UFX1204 and UFX1604 have Synchronous endpoints to which > current ALSA code applies implicit feedback sync as if they were > Asynchronous endpoints. This breaks UAC compliance and is unneeded. > > The commit 5e35dc0338d85ccebacf3f77eca1e5dea73155e8 and subsequent > 1a15718b41df026cffd0e42cfdc38a1384ce19f9 were meant to clear up noise. > > Unfortunately, noise persisted for those using higher sample rates and > this was only solved by commit d2e8f641257d0d3af6e45d6ac2d6f9d56b8ea964 > > Since there are no more reports of noise, let's get rid of the > implicit-fb quirks breaking UAC compliance. > > Signed-off-by: Geraldo Nascimento Thanks, applied now. Takashi