From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF2EC4338F for ; Thu, 19 Aug 2021 14:53:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED94F6113D for ; Thu, 19 Aug 2021 14:53:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ED94F6113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3E1BB167D; Thu, 19 Aug 2021 16:52:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3E1BB167D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1629384825; bh=vuP0HnfnVOnS24GTV4VtRCHPrmajwghzKrm1rkCOkI4=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TVP4/KzRTuEUO//Mh/fj0VyUQ6QyzBujvmTfuKg5FqdI0WYomnvxW/NBhvAJ/6yjO 1p9sAAAVMPiyHG1czUQBO4UexjG2iYsUxiv1qI/YIVE1NE43hobAH7TN9bmwKt5d/v yRP2i8eYDPlCdZ/K9IVPU1F5GX7lHkTymanw4Q3A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C9585F800F8; Thu, 19 Aug 2021 16:52:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3EA92F8026D; Thu, 19 Aug 2021 16:52:53 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D9660F800F8 for ; Thu, 19 Aug 2021 16:52:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D9660F800F8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="s6/ETgZV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5pBIuqlb" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 6F7CD1FDA8; Thu, 19 Aug 2021 14:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1629384768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aTv1RGLUMdRpTNmzj7L1UknsfahA63JeJXTiKCnBOIM=; b=s6/ETgZVDb0IyvBn/sfuj+iVtZvVVTCOy8+CUlEFjoyxCHnwiMSrSSsWLWzvX5a5uq+FDy qQ0sixYa8ogN8wMTfTtZNvff9hNCKIj0qU2LftmAhmF9fMVhPs91irNM/gKlrZHMuvOna3 RB9kvIbtkjF/eVD6qpnkSRzJ9uuE0Ro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1629384768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aTv1RGLUMdRpTNmzj7L1UknsfahA63JeJXTiKCnBOIM=; b=5pBIuqlb6iFYvfdcFsI2AWMMOeicavLeVu7OXFTEIdzz3exzS9PVo4FRbiGvlonYODEqjk UYB2GIwaxV5dLbAw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 63EC4A3BA6; Thu, 19 Aug 2021 14:52:48 +0000 (UTC) Date: Thu, 19 Aug 2021 16:52:48 +0200 Message-ID: From: Takashi Iwai To: Hans de Goede Subject: Re: [5.14 regression] "ASoC: intel: atom: Fix reference to PCM buffer address" breaks Intel SST audio In-Reply-To: References: <2048c6aa-2187-46bd-6772-36a4fb3c5aeb@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "alsa-devel@alsa-project.org" , Mark Brown , Pierre-Louis Bossart X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 19 Aug 2021 16:45:19 +0200, Hans de Goede wrote: > > Hi, > > On 8/19/21 4:42 PM, Hans de Goede wrote: > > Hi All, > > > > After rebasing a set of bytcr_rt5640 patches, on top of asoc/for-next > > I noticed that playing back audio would only generate random-noise / buzzing > > (I did not try recording any audio). > > > > After poking at this for a while I've found the culprit: > > > > 2e6b836312a4 ("ASoC: intel: atom: Fix reference to PCM buffer address") > > > > If I revert that single commit then audio on Intel Bay Trail and > > Cherry Trail devices works fine again with 5.14. > > > > This is with a Fedora 34 userspace using pipewire as audiodaemon > > > > I'm not sure what is going on here, but since the old code > > changed by the broken commit has worked fine for ages and > > given where we are in the devel-cycle I think it might be best > > to just revert 2e6b836312a4 again. > > p.s. to be clear I noticed this after rebasing on top of asoc/for-next > but the troublesome commit is actually in Linus tree now and thus > will hit end users once 5.14 is released. > > (the troublesome commit landed in 5.14-rc6 and my previous tests > were with 5.14-rc5) Ah, the commit might be problematic on 5.14 where dma_addr isn't set yet for the CONTINUOUS buffer type (which was fixed in sound.git for-next branch). Could you try the patch below? thanks, Takashi --- --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -127,7 +127,7 @@ static void sst_fill_alloc_params(struct snd_pcm_substream *substream, snd_pcm_uframes_t period_size; ssize_t periodbytes; ssize_t buffer_bytes = snd_pcm_lib_buffer_bytes(substream); - u32 buffer_addr = substream->runtime->dma_addr; + u32 buffer_addr = virt_to_phys(substream->runtime->dma_area); channels = substream->runtime->channels; period_size = substream->runtime->period_size;