From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB5DC433E0 for ; Mon, 8 Feb 2021 10:05:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2069264EAA for ; Mon, 8 Feb 2021 10:05:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2069264EAA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B708586E; Mon, 8 Feb 2021 11:04:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B708586E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612778705; bh=STEp/iklbSLYDeK13o2vBz6g8TxhW9CAnqBYQ2Wlrrc=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=H8uOqreoTrKVH3LEwO7hU5Dm6eIKCvzr8dt2UPABU06YiZWzsF4kL9aMqslUoBblD p19Ai/RQhNHqUNNm1WCZ8i5feSGLh/i6DUiyolUNgYnIUtv0HR4/5c9J+vqilVInoJ 66OqrtlS3IO5OQGkp9U2BH+s6m1JoKJaO2vF7djU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 35215F80169; Mon, 8 Feb 2021 11:04:15 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C1986F80169; Mon, 8 Feb 2021 11:04:13 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8B3DDF8013A for ; Mon, 8 Feb 2021 11:04:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8B3DDF8013A X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7D433AC6E; Mon, 8 Feb 2021 10:04:02 +0000 (UTC) Date: Mon, 08 Feb 2021 11:04:02 +0100 Message-ID: From: Takashi Iwai To: Hans de Goede Subject: Re: [PATCH 1/2] ALSA: hda: intel-dsp-config: Add FLAG_BYT_FIRST / _SECOND defines In-Reply-To: <20210208093800.62099-1-hdegoede@redhat.com> References: <20210208093800.62099-1-hdegoede@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Cezary Rojewski , Takashi Iwai , Pierre-Louis Bossart , alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 08 Feb 2021 10:37:59 +0100, Hans de Goede wrote: > > Instead of hardcording the SST driver having the highest prio, add > FLAG_BYT_FIRST and FLAG_BYT_SECOND defines, which get set like this > when both drivers are enabled: > > #define FLAG_BYT_FIRST FLAG_SST > #define FLAG_BYT_SECOND FLAG_SOF > > And when only 1 driver is enabled then FLAG_BYT_FIRST gets set to > the flag for that driver. > > This is a preparation patch for making which driver is preferred > configurable through Kconfig. > > Signed-off-by: Hans de Goede I find the idea is fine, but the ifdef conditions become too complex after this change. It took minutes to check whether the ifdef changes are really correct for me :) So, it'd be appreciated if this can be re-designed and simplified... Takashi