From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F06C388F2 for ; Thu, 22 Oct 2020 13:21:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FF7C2417D for ; Thu, 22 Oct 2020 13:21:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="RKIgYJay" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FF7C2417D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 58B3E17B9; Thu, 22 Oct 2020 15:20:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 58B3E17B9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603372905; bh=txwEKPzDbislGiJ1f0iEEb3tuMPQxz3eWniCiB97Auo=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RKIgYJayXQHkqKd/M+BHbbdt31yfbf1AjlG1xtkzG1SB2YIKdxNEPI8NddnPsobP2 xZgM7xmN3g6cZO6+K/Yej4YkWKMgoXSpslTqg7Lj3RMlgRyFlswUwWqi1sGEDFgLJZ DKb2PQ24lMMWFMUeULt3iumPX1aYE5zNJlvQXMyY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DC4C2F8049C; Thu, 22 Oct 2020 15:20:54 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7C62CF804A9; Thu, 22 Oct 2020 15:20:53 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F0B7FF800CE for ; Thu, 22 Oct 2020 15:20:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F0B7FF800CE X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EC29CB904; Thu, 22 Oct 2020 13:20:49 +0000 (UTC) Date: Thu, 22 Oct 2020 15:20:49 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Subject: Re: Context expectations in ALSA In-Reply-To: <20201022125741.xxibhwgcr2mhxehe@gilmour.lan> References: <20201022095041.44jytaelnlako54w@gilmour.lan> <30226f94-72e9-34d2-17d0-11d2501053f0@perex.cz> <20201022125741.xxibhwgcr2mhxehe@gilmour.lan> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Dom Cobley , Dave Stevenson , linux-kernel@vger.kernel.org, Liam Girdwood , Takashi Iwai , Mark Brown , Nicolas Saenz Julienne X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 22 Oct 2020 14:57:41 +0200, Maxime Ripard wrote: > > On Thu, Oct 22, 2020 at 12:03:19PM +0200, Jaroslav Kysela wrote: > > Dne 22. 10. 20 v 11:50 Maxime Ripard napsal(a): > > > > > So, I'm not really sure what I'm supposed to do here. The drivers > > > involved don't appear to be doing anything extraordinary, but the issues > > > lockdep report are definitely valid too. What are the expectations in > > > terms of context from ALSA when running the callbacks, and how can we > > > fix it? > > > > I think that you should set the non-atomic flag and wake up the workqueue or > > so from interrupt handler in this case. Call snd_pcm_period_elapsed() from the > > workqueue not the interrupt handler context. > > Yeah, that was my first guess too. However, the DMA driver uses some > kind of generic helpers using a tasklet, so getting rid of it would take > some work and would very likely not be eligible for stable. Who sets the nonatomic flag for vc4? I couldn't find the relevant code in the latest upstream. Ideally dmaengine PCM helper should support the nonatomic mode, but until then, the other side needs to drop the nonatomic flag, I suppose. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD190C388F2 for ; Thu, 22 Oct 2020 13:21:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8DD0424182 for ; Thu, 22 Oct 2020 13:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2899789AbgJVNVK (ORCPT ); Thu, 22 Oct 2020 09:21:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:50340 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2899739AbgJVNUv (ORCPT ); Thu, 22 Oct 2020 09:20:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EC29CB904; Thu, 22 Oct 2020 13:20:49 +0000 (UTC) Date: Thu, 22 Oct 2020 15:20:49 +0200 Message-ID: From: Takashi Iwai To: Maxime Ripard Cc: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Dom Cobley , Dave Stevenson , Nicolas Saenz Julienne Subject: Re: Context expectations in ALSA In-Reply-To: <20201022125741.xxibhwgcr2mhxehe@gilmour.lan> References: <20201022095041.44jytaelnlako54w@gilmour.lan> <30226f94-72e9-34d2-17d0-11d2501053f0@perex.cz> <20201022125741.xxibhwgcr2mhxehe@gilmour.lan> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Oct 2020 14:57:41 +0200, Maxime Ripard wrote: > > On Thu, Oct 22, 2020 at 12:03:19PM +0200, Jaroslav Kysela wrote: > > Dne 22. 10. 20 v 11:50 Maxime Ripard napsal(a): > > > > > So, I'm not really sure what I'm supposed to do here. The drivers > > > involved don't appear to be doing anything extraordinary, but the issues > > > lockdep report are definitely valid too. What are the expectations in > > > terms of context from ALSA when running the callbacks, and how can we > > > fix it? > > > > I think that you should set the non-atomic flag and wake up the workqueue or > > so from interrupt handler in this case. Call snd_pcm_period_elapsed() from the > > workqueue not the interrupt handler context. > > Yeah, that was my first guess too. However, the DMA driver uses some > kind of generic helpers using a tasklet, so getting rid of it would take > some work and would very likely not be eligible for stable. Who sets the nonatomic flag for vc4? I couldn't find the relevant code in the latest upstream. Ideally dmaengine PCM helper should support the nonatomic mode, but until then, the other side needs to drop the nonatomic flag, I suppose. thanks, Takashi