From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB45AC28CBC for ; Sun, 3 May 2020 19:04:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 499C0206F1 for ; Sun, 3 May 2020 19:04:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="bz00MtT2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 499C0206F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 94C4516C7; Sun, 3 May 2020 21:03:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 94C4516C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588532643; bh=QbN0I1zGglkSoU4AXC8kFqgpbArmrPwdMXk1Xxk2NNE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bz00MtT2kKzM0pbWGM2Z0uJbNS2pArawsONKUrDHWdGasyBJTyeDklokYbYs0hNfk OzenPPVWvtfMiH+AvHSrfSpk/3taG/vw5WL78a+P19BMZUYTzl4uRHjoFby5cdoAFc Os9+kGog8VcSmbK62uymFnKYP8+s3GtMibDGuQEg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5317EF80171; Sun, 3 May 2020 21:02:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 83663F801D9; Sun, 3 May 2020 21:02:33 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A8CFBF80162 for ; Sun, 3 May 2020 21:02:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A8CFBF80162 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CA185ADE2; Sun, 3 May 2020 19:02:26 +0000 (UTC) Date: Sun, 03 May 2020 21:02:25 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Subject: Re: [PATCH 2/2] ALSA: hda/realtek - Fix S3 pop noise on Dell Wyse In-Reply-To: <20200503152449.22761-2-kai.heng.feng@canonical.com> References: <20200503152449.22761-1-kai.heng.feng@canonical.com> <20200503152449.22761-2-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "moderated list:SOUND" , Kailang Yang , Tomas Espeleta , open list , David_chen7@dell.com, tiwai@suse.com, Hui Wang , Thomas Hebb , Jian-Hong Pan , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 03 May 2020 17:24:47 +0200, Kai-Heng Feng wrote: > > Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to > 0") makes the ALC225 have pop noise on S3 resume and cold boot. > > The previous fix enable power save node universally for ALC225, however > it makes some ALC225 systems unable to produce any sound. > > So let's only enable power save node for the affected Dell Wyse > platform. > > Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") > BugLink: https://bugs.launchpad.net/bugs/1866357 > Signed-off-by: Kai-Heng Feng Applied, thanks. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E036C28CBC for ; Sun, 3 May 2020 19:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00C87206EB for ; Sun, 3 May 2020 19:02:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729005AbgECTC1 (ORCPT ); Sun, 3 May 2020 15:02:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:47670 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728847AbgECTC0 (ORCPT ); Sun, 3 May 2020 15:02:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CA185ADE2; Sun, 3 May 2020 19:02:26 +0000 (UTC) Date: Sun, 03 May 2020 21:02:25 +0200 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: , , Jaroslav Kysela , Kailang Yang , Hui Wang , Jian-Hong Pan , Tomas Espeleta , Thomas Hebb , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , "moderated list:SOUND" , open list Subject: Re: [PATCH 2/2] ALSA: hda/realtek - Fix S3 pop noise on Dell Wyse In-Reply-To: <20200503152449.22761-2-kai.heng.feng@canonical.com> References: <20200503152449.22761-1-kai.heng.feng@canonical.com> <20200503152449.22761-2-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 03 May 2020 17:24:47 +0200, Kai-Heng Feng wrote: > > Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to > 0") makes the ALC225 have pop noise on S3 resume and cold boot. > > The previous fix enable power save node universally for ALC225, however > it makes some ALC225 systems unable to produce any sound. > > So let's only enable power save node for the affected Dell Wyse > platform. > > Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") > BugLink: https://bugs.launchpad.net/bugs/1866357 > Signed-off-by: Kai-Heng Feng Applied, thanks. Takashi