All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Valentin Corfu <corfuvalentin@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] jack: Fixing a small memory leak
Date: Mon, 10 Aug 2015 17:09:57 +0200	[thread overview]
Message-ID: <s5ha8tz41tm.wl-tiwai@suse.de> (raw)
In-Reply-To: <1439218706-30721-2-git-send-email-corfuvalentin@gmail.com>

On Mon, 10 Aug 2015 16:58:26 +0200,
Valentin Corfu wrote:
> 
> Signed-off-by: Valentin Corfu <corfuvalentin@gmail.com>

So you found out the very same fix :)

But please put more description in the commit log.  For example, the
valgrind output you cited would be a good material.


thanks,

Takashi

> ---
>  jack/pcm_jack.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/jack/pcm_jack.c b/jack/pcm_jack.c
> index 568ec43..de9c46e 100644
> --- a/jack/pcm_jack.c
> +++ b/jack/pcm_jack.c
> @@ -103,6 +103,7 @@ static void snd_pcm_jack_free(snd_pcm_jack_t *jack)
>  		if (jack->io.poll_fd >= 0)
>  			close(jack->io.poll_fd);
>  		free(jack->areas);
> +		free(jack->ports);
>  		free(jack);
>  	}
>  }
> -- 
> 1.9.1
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2015-08-10 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 14:58 jack: Fixing a small memory leak Valentin Corfu
2015-08-10 14:58 ` [PATCH] " Valentin Corfu
2015-08-10 15:09   ` Takashi Iwai [this message]
2015-08-10 15:07 ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2015-08-11  6:37 [PATCH] " Valentin Corfu
2015-08-11  7:39 ` Takashi Iwai
2015-08-11  7:43   ` Valentin Corfu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ha8tz41tm.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=corfuvalentin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.