From: Takashi Iwai <tiwai@suse.de>
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org, Clemens Ladisch <clemens@ladisch.de>
Subject: Re: [PATCH 1/3] ALSA: usb: move ua101 driver
Date: Mon, 01 Mar 2010 15:06:57 +0100 [thread overview]
Message-ID: <s5haaus16gu.wl%tiwai@suse.de> (raw)
In-Reply-To: <20100301140129.GI28972@buzzloop.caiaq.de>
At Mon, 1 Mar 2010 15:01:29 +0100,
Daniel Mack wrote:
>
> On Mon, Mar 01, 2010 at 12:27:31PM +0100, Clemens Ladisch wrote:
> > Daniel Mack wrote:
> > > As part of the USB audio code cleanup, move the non-standard ua101
> > > driver out of the way.
> >
> > A directory with a single source file in it isn't quite an improvement.
> > Please name it "misc" so that other specialized drivers could be put in
> > there.
>
> Ok, will do. However, I wonder which way is best to do that. Given that
> you posted patches on top of mine, can I take this as a general
> agreement to my changeset? If so, I will just provide a patch on top to
> do the ua101 -> misc rename, because otherwise, I would have to rebase
> all three patches for that.
Well, honestly, I prefer seeing the fixes by Clemens based on the
current code, and merge Daniel's refactoring patches after 2.6.34
merge window.
Refactoring is a good thing but it can easily introduce any careless
bugs (like copy&paste error), and this split action makes really hard
to track the changes. Thus I'd like to keep this well ripened before
reaching to the Linus tree, not only for a few days.
thanks,
Takashi
next prev parent reply other threads:[~2010-03-01 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 14:34 [RFC] Cleanup/refactor the usbaudio driver Daniel Mack
2010-02-26 14:34 ` [PATCH 1/3] ALSA: usb: move ua101 driver Daniel Mack
2010-02-26 14:34 ` [PATCH 2/3] ALSA: usb: header file cleanups Daniel Mack
[not found] ` <1267194883-6854-4-git-send-email-daniel@caiaq.de>
2010-03-01 11:27 ` [PATCH 1/3] ALSA: usb-audio: rename substream format field to altset_idx Clemens Ladisch
2010-03-01 11:27 ` [PATCH 2/3] ALSA: usb-audio: use a format bitmask per alternate setting Clemens Ladisch
2010-03-01 11:27 ` [PATCH 3/3] ALSA: usb-audio: support multiple formats with audio class v2 devices Clemens Ladisch
2010-03-01 14:26 ` Daniel Mack
2010-03-01 15:26 ` Clemens Ladisch
2010-03-01 11:27 ` [PATCH 1/3] ALSA: usb: move ua101 driver Clemens Ladisch
2010-03-01 14:01 ` Daniel Mack
2010-03-01 14:06 ` Takashi Iwai [this message]
2010-03-01 14:18 ` Daniel Mack
2010-03-01 14:23 ` Takashi Iwai
2010-03-04 15:16 ` Daniel Mack
2010-03-04 15:31 ` Takashi Iwai
2010-03-04 15:38 ` Daniel Mack
2010-03-04 15:43 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5haaus16gu.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=daniel@caiaq.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.