From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262315AbVG2J4R (ORCPT ); Fri, 29 Jul 2005 05:56:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262561AbVG2JrW (ORCPT ); Fri, 29 Jul 2005 05:47:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:26275 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S262554AbVG2Jqx (ORCPT ); Fri, 29 Jul 2005 05:46:53 -0400 Date: Fri, 29 Jul 2005 11:46:47 +0200 Message-ID: From: Takashi Iwai To: Dave Jones Cc: Lee Revell , Andrew Morton , Jaroslav Kysela , torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [ALSA PATCH] 1.0.9b+ In-Reply-To: <20050728210738.GC2231@redhat.com> References: <20050728102525.234e6511.akpm@osdl.org> <1122577563.2772.17.camel@mindpipe> <20050728210738.GC2231@redhat.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta18) (chestnut) (+CVS-20041021) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 28 Jul 2005 17:07:38 -0400, Dave Jones wrote: > > On Thu, Jul 28, 2005 at 03:06:02PM -0400, Lee Revell wrote: > > > > The git-alsa.patch in -mm which I obtain from > > > master.kernel.org:/pub/scm/linux/kernel/git/perex/alsa-current.git is > > > empty. So we're now wanting to merge 4,000 lines of unreviewed code which > > > hasn't been tested in -mm at approximately the -rc4 stage. > > > > Lots of people install ALSA independently from the kernel (like all the > > audio oriented distro users), probably a lot more than run -mm, so it's > > not completely unreviewed. > > There's a big difference between 'unreviewed' and 'untested'. > With drivers that support n variants of a piece of hardware, > hearing back that a driver works fine from someone isn't really > worth anything if the changes break for all the other users > of that driver that have a different variant, which haven't tested it yet. > > We have a testing/review process in place, attempts to short-circuit > it should be prevented. Especially from a subsystem that > historically has had a number of issues wrt regressions each release. Oh, I missed your talk in OLS ;) Basically I agree with the argument above. Some hardware-specific regressions are very hard to find only from review. The famous problem with ThinkPad in the last update was such a kind. More tests in a bigger place like mm tree would be required, indeed. Unfortunately, the sync between ALSA and mm tree didn't work well because of troubles with git/cogito at this time. The sync process shall be improved from now on. So, please consider this as an exception. Takashi