Re: 1.0.5rc1 release

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

At Tue, 25 May 2004 14:41:31 +0200,
I wrote:
> 
> At Tue, 25 May 2004 14:26:33 +0200 (METDST),
> Clemens Ladisch wrote:
> > 
> > > Please, report (especially compilation) problems.
> > 
> > depmod: *** Unresolved symbols in
> > /lib/modules/2.4.26/kernel/sound/isa/wavefront/snd-wavefront.o
> > depmod:         errno
> > 
> > The open/close/read system calls are implemented as inline functions
> > which change errno which isn't exported from the kernel.
> > 
> > We could reintroduce the dummy definition of errno for older kernels,
> > or use filp_* calls (like sound_firmware.c).
> 
> i guess sys_* functions are also not defined correctly on older
> kernels.  they were open(), close(), read() with __KERNEL_SYSCALLS__.

does the attached patch work?


Takashi

[-- Attachment #2: Type: text/plain, Size: 691 bytes --]

Index: alsa-driver/isa/wavefront/wavefront_synth.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-driver/isa/wavefront/wavefront_synth.c,v
retrieving revision 1.3
diff -u -r1.3 wavefront_synth.c
--- alsa-driver/isa/wavefront/wavefront_synth.c	24 Apr 2004 19:54:17 -0000	1.3
+++ alsa-driver/isa/wavefront/wavefront_synth.c	25 May 2004 12:55:43 -0000
@@ -5,6 +5,11 @@
 
 #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,5)
 #define __KERNEL_SYSCALLS__
+#include <linux/unistd.h>
+#define sys_open open
+#define sys_close close
+#define sys_read read
+static int errno;
 #endif
 
 #include "../../alsa-kernel/isa/wavefront/wavefront_synth.c"