From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] fix ymfpci port parameter handling Date: Tue, 28 Oct 2003 12:30:41 +0100 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: Clemens Ladisch Cc: perex@suse.cz, alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Mon, 27 Oct 2003 12:34:01 +0100 (MET), Clemens Ladisch wrote: > > Takashi Iwai wrote: > > Clemens Ladisch wrote: > > > - fix detection of omitted (default) joystick_port parameter > > > - make fm_port and mpu_port handling consistent with joystick_port > > > > i think it'd be better to check all *_port parameters of all modules > > to use the consistent values. so far, some drivers use the value 0 to > > disable the device, some -1, and sometimes -1 is for the > > auto-detection. > > > > yes, it's cosmetic but important. we need to define the standard > > values before ALSA 1.0 is out. > > > > the candidates are: > > > > a) -1 = disable, 0 = auto-detect, others = manual > > b) 0 = disable, -1 = auto-detect, others = manual > > c) 0 = disable, 1 = auto-detect, others = manual > > d) 0 = disable, -1 = auto-detect, others = manual > > > > i like the case (c) or (d). > > I'm for (c): When autodetection is available, the parameter can behave > like a boolean, so "1" would be the least suprising value for a > 'generic enable'. > > And you've already begun to implement (c) anyway. :-) yeah :) now i changed the cvs code. the affected drivers are: als4000, azt3328, cmipci, ens1370, via82xx, ymfpci Takashi ------------------------------------------------------- This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/