From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE8B1C4338F for ; Mon, 9 Aug 2021 14:05:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4D5A460EC0 for ; Mon, 9 Aug 2021 14:05:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D5A460EC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 382771616; Mon, 9 Aug 2021 16:05:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 382771616 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628517954; bh=HgC/VWGv2Qwt/CLzlVN9Bpf+GFTcqSvDiXXYG5Ww5E4=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bTQqr6sB2OSeckzDTT1drfNKHfznXyIW7fkNnGhnsc3UhNyuuErsKsMRLmmzQ6kV4 PFJcTvsFjVqNf8AjBd/Xd5oI+dJhezi5rK/w9jliVktzt3YLDtE/3HPHZQ/CaUKVAL EISeDl5haGx3XM88gKGyfjf2LcLLecXLoQU+dll4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A8285F80105; Mon, 9 Aug 2021 16:05:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9420EF802D2; Mon, 9 Aug 2021 16:05:02 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2AB63F800C8 for ; Mon, 9 Aug 2021 16:04:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2AB63F800C8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="DSNTVpj9"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="sCQ8dyoL" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 47F8321EC2 for ; Mon, 9 Aug 2021 14:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628517897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g0vaGV4/2RqTwOuv7W7z/RjEHRRbpiveOOryYF4HvtU=; b=DSNTVpj9gPt+gky4TDMuPiSYCQOsM1NG7BSjBGhLVW7f8MCQBOTMeteG6w3jSoyx7aB69Q w4rv/xRpj0Swxx8M+tezVowelvVX68qhdb9An+IeUTbESR11qFwujKZPk1sia9ZnIii7nC +9tJ4479gJMDxLrvS1AlO7o9VQkOJCE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628517897; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g0vaGV4/2RqTwOuv7W7z/RjEHRRbpiveOOryYF4HvtU=; b=sCQ8dyoLiqk5hDTcrLsOW9rJDRTOjjI0oL0wEnfd/Zq72EEp6xjxVkg8gXfYCYRRxJZUiD Whjhsd5UqzYaaTCg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 376D8A3B81 for ; Mon, 9 Aug 2021 14:04:57 +0000 (UTC) Date: Mon, 09 Aug 2021 16:04:57 +0200 Message-ID: From: Takashi Iwai To: alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: msnd: Use proper mmap method In-Reply-To: <20210809135926.8687-1-tiwai@suse.de> References: <20210809135926.8687-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 09 Aug 2021 15:59:26 +0200, Takashi Iwai wrote: > > The old ISA MSND driver basically maps the iomem as the DMA buffer. > For this type of buffer, we have already the standard mmap helper, > snd_pcm_lib_mmap_iomem(). Set the DMA address and use the standard > helper for allowing the mmap on all architectures properly. We need to set the different PCM INFO flag for this. Will resubmit v2 patch covering that, too. Takashi