From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1727AC4361B for ; Mon, 14 Dec 2020 07:59:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9110522838 for ; Mon, 14 Dec 2020 07:59:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9110522838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EA6DB1727; Mon, 14 Dec 2020 08:58:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EA6DB1727 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1607932785; bh=3tXnwyz/xLjPAShIuR7y13O33lymhQ2hvlYIpEZia/o=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OXDSDUgC79l1S3+qgD+2L8XDLACVA7VHeh7LvZI3lRjKtJbJmLvmcqs/CtXLbltED MGBwrcNdv0ZCsQc9pR2QhX3qRlJh53Q/FOfUCvExVBq51shojIDKr8TsFXvPSn3U6u pq+2MwrgXw/lUc396G8+YN4xD7sLJQr1d+tJzwDs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 74B72F80171; Mon, 14 Dec 2020 08:58:54 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 997A5F801F7; Mon, 14 Dec 2020 08:58:52 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7960FF80129 for ; Mon, 14 Dec 2020 08:58:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7960FF80129 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 55EAFAC10; Mon, 14 Dec 2020 07:58:44 +0000 (UTC) Date: Mon, 14 Dec 2020 08:58:44 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Subject: Re: [PATCH] ALSA: hda: Enable runtime PM when codec probe fails In-Reply-To: <20201214060621.1102931-1-kai.heng.feng@canonical.com> References: <20201214060621.1102931-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Guennadi Liakhovetski , "moderated list:SOUND" , Kai Vehmanen , open list , Pierre-Louis Bossart , tiwai@suse.com, Alex Deucher , Mike Rapoport X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 14 Dec 2020 07:06:20 +0100, Kai-Heng Feng wrote: > > When codec probe fails, it doesn't enable runtime suspend, and can > prevent graphics card from getting powered down: > [ 4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized > > $ cat /sys/bus/pci/devices/0000:01:00.1/power/runtime_status > active > > So enable runtime PM when codec probe fails, to let graphics card be > able to runtime suspend again. Well, the runtime status is also active if the driver isn't probed at all. In that sense, keeping the status active at the driver load failure is rather consistent, IMO. If the driver fails or unloaded, it should restore the status as if it were beforehand. thanks, Takashi > > Merge azx_probe_continue() into azx_probe() and just let probe fail for > this case could be a better approach. However that's a much bigger task > so let's settle with a quirk workaround. > > BugLink: https://bugs.launchpad.net/bugs/1907212 > Signed-off-by: Kai-Heng Feng > --- > sound/pci/hda/hda_intel.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 6852668f1bcb..3fd920069268 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2328,7 +2328,7 @@ static int azx_probe_continue(struct azx *chip) > if (bus->codec_mask) { > err = azx_probe_codecs(chip, azx_max_codecs[chip->driver_type]); > if (err < 0) > - goto out_free; > + goto out_enable_rpm; > } > > #ifdef CONFIG_SND_HDA_PATCH_LOADER > @@ -2360,6 +2360,7 @@ static int azx_probe_continue(struct azx *chip) > > set_default_power_save(chip); > > +out_enable_rpm: > if (azx_has_pm_runtime(chip)) { > pm_runtime_use_autosuspend(&pci->dev); > pm_runtime_allow(&pci->dev); > -- > 2.29.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0250C4361B for ; Mon, 14 Dec 2020 07:59:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DEBA225AC for ; Mon, 14 Dec 2020 07:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438967AbgLNH70 (ORCPT ); Mon, 14 Dec 2020 02:59:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:40644 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728424AbgLNH70 (ORCPT ); Mon, 14 Dec 2020 02:59:26 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 55EAFAC10; Mon, 14 Dec 2020 07:58:44 +0000 (UTC) Date: Mon, 14 Dec 2020 08:58:44 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: tiwai@suse.com, Jaroslav Kysela , Kai Vehmanen , Pierre-Louis Bossart , Guennadi Liakhovetski , Alex Deucher , Mike Rapoport , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] ALSA: hda: Enable runtime PM when codec probe fails In-Reply-To: <20201214060621.1102931-1-kai.heng.feng@canonical.com> References: <20201214060621.1102931-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Dec 2020 07:06:20 +0100, Kai-Heng Feng wrote: > > When codec probe fails, it doesn't enable runtime suspend, and can > prevent graphics card from getting powered down: > [ 4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized > > $ cat /sys/bus/pci/devices/0000:01:00.1/power/runtime_status > active > > So enable runtime PM when codec probe fails, to let graphics card be > able to runtime suspend again. Well, the runtime status is also active if the driver isn't probed at all. In that sense, keeping the status active at the driver load failure is rather consistent, IMO. If the driver fails or unloaded, it should restore the status as if it were beforehand. thanks, Takashi > > Merge azx_probe_continue() into azx_probe() and just let probe fail for > this case could be a better approach. However that's a much bigger task > so let's settle with a quirk workaround. > > BugLink: https://bugs.launchpad.net/bugs/1907212 > Signed-off-by: Kai-Heng Feng > --- > sound/pci/hda/hda_intel.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 6852668f1bcb..3fd920069268 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2328,7 +2328,7 @@ static int azx_probe_continue(struct azx *chip) > if (bus->codec_mask) { > err = azx_probe_codecs(chip, azx_max_codecs[chip->driver_type]); > if (err < 0) > - goto out_free; > + goto out_enable_rpm; > } > > #ifdef CONFIG_SND_HDA_PATCH_LOADER > @@ -2360,6 +2360,7 @@ static int azx_probe_continue(struct azx *chip) > > set_default_power_save(chip); > > +out_enable_rpm: > if (azx_has_pm_runtime(chip)) { > pm_runtime_use_autosuspend(&pci->dev); > pm_runtime_allow(&pci->dev); > -- > 2.29.2 >