From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org, Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [bug report] ALSA: hda - Don't register a cb func if it is registered already
Date: Wed, 21 Oct 2020 17:59:34 +0200 [thread overview]
Message-ID: <s5hblgvefix.wl-tiwai@suse.de> (raw)
In-Reply-To: <9be5bc31-0118-1542-560f-cfe2cecf2403@canonical.com>
On Wed, 21 Oct 2020 17:03:11 +0200,
Hui Wang wrote:
>
> Looks like this will not bring problem on patch_sigmatel.c, NULL and
> valid kernel pointer are same for IS_ERR(), they will not make
> IS_ERR() come true.
Right, and it's called only once, so the bug doesn't hit.
But we should address the potential bug nevertheless, of course :)
thanks,
Takashi
next prev parent reply other threads:[~2020-10-21 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 12:19 [bug report] ALSA: hda - Don't register a cb func if it is registered already Dan Carpenter
2020-10-21 14:21 ` Hui Wang
2020-10-21 15:03 ` Hui Wang
2020-10-21 15:59 ` Takashi Iwai [this message]
2020-10-22 1:45 ` Hui Wang
2020-10-21 17:27 ` Dan Carpenter
2020-10-22 1:42 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hblgvefix.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=hui.wang@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.