From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9BEBCA9EAE for ; Tue, 29 Oct 2019 13:57:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2CE7214B2 for ; Tue, 29 Oct 2019 13:57:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="WKEF7Arr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2CE7214B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9C6FF2259; Tue, 29 Oct 2019 14:56:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9C6FF2259 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572357440; bh=OB8x6XvDLyqq+57uGwbqeP8qZrUId+9Dnv/YQnQ+NW0=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WKEF7ArrriGTywYWPHQNyMVsPsDgrgU9Sn8rxj8YZddUp06VR25mIY+FSRNlZQFPh UcWfp/OwrkBcofd1J6gyiIOh271IQBPq+ZTXuc4Se4kCHK8qzF5qrc8+JyL3IOO0X+ f5EsnyXAiVxkOWuABOrVbtVmX7j5h6PaUHGVj0kU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 382A3F80269; Tue, 29 Oct 2019 14:56:30 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5B60DF80392; Tue, 29 Oct 2019 14:56:29 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DF030F800E7 for ; Tue, 29 Oct 2019 14:56:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DF030F800E7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E9B5EB4D2; Tue, 29 Oct 2019 13:56:25 +0000 (UTC) Date: Tue, 29 Oct 2019 14:56:25 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen In-Reply-To: <20191029134017.18901-1-kai.vehmanen@linux.intel.com> References: <20191029134017.18901-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: libin.yang@intel.com, julia.lawall@lip6.fr, alsa-devel@alsa-project.org, broonie@kernel.org, pierre-louis.bossart@linux.intel.com Subject: Re: [alsa-devel] [PATCH v8 0/9] adapt SOF to use snd-hda-codec-hdmi X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 29 Oct 2019 14:40:08 +0100, Kai Vehmanen wrote: > > Hey, > here's the 8th round for this series that adapts SOF to use > snd-hda-codec-hdmi (patch_hdmi.c) codec driver instead of hdac_hdmi > (soc/codecs/hdac_hdmi.c). The primary goal is to unify the HDMI codec > implementation between DSP and non-DSP HDA configurations, offer same > interface to user-space and reduce maintenance load for all. > > Intended to go in via Mark's ASoC tree. > > v8 changes: > - rebased on top of Mark's for-next (50484b6a523a) > - addressed Takashi's review comment to patch 5 > - addressed two sparse warnings in patch 3 reported by > kbuild test robot > - fixed itnull.cocci warning in patch 3 reported by > Julia Lawall and > kbuild test robot > > Feature and testing info: > - Tested on multiple Intel platforms supported by SOF. > - Tested with ALSA console tools as well as with Pulseaudio. > - requires Pulseaudio 12.x or newer, see > https://lists.freedesktop.org/archives/pulseaudio-discuss/2019-August/031358.html > - HDMI, DP, DP-MST with multi-monitor use-scenarios work ok. > - New feature for SOF: ELD /proc fs works just like in > DSP-less mode. > - New feature for SOF: jack detection works out-of-the-box > with Pulseaudio (no need for card specific UCM for HDMI) > > Kai Vehmanen (9): > ALSA: hda/hdmi - implement mst_no_extra_pcms flag > ASoC: hdac_hda: add support for HDMI/DP as a HDA codec > ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmi > ASoC: Intel: skl-hda-dsp-generic: fix include guard name > ASoC: SOF: Intel: add support for snd-hda-codec-hdmi > ASoC: Intel: bxt-da7219-max98357a: common hdmi codec support > ASoC: Intel: glk_rt5682_max98357a: common hdmi codec support > ASoC: intel: sof_rt5682: common hdmi codec support > ASoC: Intel: bxt_rt298: common hdmi codec support Looks good to me. For the whole series: Reviewed-by: Takashi Iwai thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel