Re: [PATCH] pcm_dshare: Do not discard slave reported delay in status result.

[Takashi Iwai <tiwai@suse.de>]

On Thu, 17 Nov 2016 15:18:04 +0100,
Alan Young wrote:
> 
> On 17/11/16 10:31, Takashi Iwai wrote:
> > On Thu, 17 Nov 2016 09:20:16 +0100,
> > Alan Young wrote:
> >> snd_pcm_dshare_status() gets the underlying status from the slave PCM.
> >> This may contain a delay value that includes elements such as codec and
> >> other transfer delays. Use this as the base for the returned delay
> >> value, adjusted for any frames buffered locally (within the dshare
> >> plugin).
> >>
> >> Note: snd_pcm_dshare_delay() is not updated.
> > Thanks for the patch, but it doesn't look like a proper patch to be
> > applied to the latest git tree.  I guess you created a patch on top of
> > the modified tree.
> >
> > Please rebase and resubmit.
> >
> > Also, don't forget to add your sign-off.  We prefer having it in
> > alsa-lib code like the kernel code (although it's not strictly
> > needed).
> 
> I can add a signoff but first I need to understand what is wrong with
> the patch.
> 
> I did a git pull of master from
> git://git.alsa-project.org/alsa-lib.git, committed my patch on top
> (previous commit a668a94238d: "mixer: Don't install smixer modules
> unless python is enabled") and did a git format-patch to generate the
> supplied patch. What did I do wrong?

Try a clean alsa-lib.git checkout and apply your patch manually there.
Then you'll see what I meant.


Takashi