From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] fix usb midi crash
Date: Mon, 13 Jan 2003 10:57:18 +0100
Sender: alsa-devel-admin@lists.sourceforge.net
Message-ID: <s5hbs2lwewx.wl@alsa2.suse.de>
References: <Pine.HPX.4.33n.0301130925050.3084-100000@studcom.urz.uni-halle.de>
Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi")
Content-Type: text/plain; charset=US-ASCII
Return-path: <alsa-devel-admin@lists.sourceforge.net>
In-Reply-To: <Pine.HPX.4.33n.0301130925050.3084-100000@studcom.urz.uni-halle.de>
Errors-To: alsa-devel-admin@lists.sourceforge.net
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

Hi Clemens,

At Mon, 13 Jan 2003 09:49:30 +0100 (MET),
Clemens Ladisch wrote:
> 
> Revision 1.14 of usbmidi.c added checks for chip->shutdown ("to be sure"),
> but chip->shutdown is always 1 when unloading, so the URBs didn't get
> unlinked at all. This caused random crashes later.
> 
> This patch adds a hook to unlink the URBs, at the same time as the PCM
> URBs.
> 
> Additionally, the card's longname now includes again the device number (as
> suggested by Pedro).


i got again "malformed patch error", perhaps in this part:

> Index: alsa-driver/include/adriver.h
> ===================================================================
> RCS file: /cvsroot/alsa/alsa-driver/include/adriver.h,v
> retrieving revision 1.27
> diff -u -r1.27 adriver.h
...
> @@ -240,6 +249,7 @@
>  #undef usb_submit_urb
>  #define usb_alloc_urb(n,flags) usb_alloc_urb_wrapper(n,flags)
>  #define usb_submit_urb(p,flags) usb_submit_urb_wrapper(p,flags)
>  #define OLD_USB
>  #endif /* LINUX_VERSION_CODE < 2.5.0 */
> 
> Index: alsa-kernel/usb/usbaudio.c
> ===================================================================


is there any change in (-240,6,+249.7)?

other parts have been already committed to cvs.
thanks,

Takashi


-------------------------------------------------------
This SF.NET email is sponsored by: FREE  SSL Guide from Thawte
are you planning your Web Server Security? Click here to get a FREE
Thawte SSL guide and find the answers to all your  SSL security issues.
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en