From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] cs46xx, independant rear PCM channel, IEC958 PCM channel
Date: Wed, 30 Oct 2002 19:19:49 +0100
Sender: alsa-devel-admin@lists.sourceforge.net
Message-ID: <s5hbs5bbxh6.wl@alsa2.suse.de>
References: <3DBE3EDA.80900@cucumelo.org>
Mime-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi")
Content-Type: text/plain; charset=US-ASCII
Return-path: <alsa-devel-admin@lists.sourceforge.net>
In-Reply-To: <3DBE3EDA.80900@cucumelo.org>
Errors-To: alsa-devel-admin@lists.sourceforge.net
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
To: Benny Sjostrand <gorm@cucumelo.org>
Cc: alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

Hi Benny,

the changes look ok, but i'd like to ask your favor before applying
this patch.

could you move the SCB initialization part in
cs46xx_playback_prepare() into hw_params callback?
i found that the mutex is not allowed in prepare callback since it's
protected by spinlock (at the very entry of prepare action).
this caused oops on 2.5.x kernels, as you might have seen a report on
alsa-devel ML.

please note that hw_params callback may be called also not only once,
so you'll need to check whether the SCB was already initialized, and
release the old allocation before re-initializing.

also, it would be appreciated if you fix the whitespaces :)


ciao,

Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf