Re: Updated: via8233 driver -- testers wanted

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

Hi,

At Fri, 31 May 2002 14:13:28 +0200,
René Kermis wrote:
> 
> Hi,
> 
> I tried to to record from mic and line in. I have no problems with
> recording, but the file is empty.
> 
> Some very strange things happend on my machine. I tried to use the oss
> module and it worked without problems. Then I uninstalled the evaluation
> version and removed the modules from memory and reloaded your modules. Now I
> can playback sounds without getting an error, but the sound is too fast,
> exactly 2x faster than it should be. Is it possible, that it is only an
> initialization problem of the sound chip?

now found out obvious typos - patch attached (already on cvs).
hopefull this fixes the problem...


Takashi

[-- Attachment #2: via-fix.dif --]
[-- Type: application/octet-stream, Size: 1092 bytes --]

Index: alsa-kernel/pci/via8233.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/via8233.c,v
retrieving revision 1.15
diff -u -r1.15 via8233.c
--- alsa-kernel/pci/via8233.c	29 May 2002 09:42:36 -0000	1.15
+++ alsa-kernel/pci/via8233.c	31 May 2002 13:23:18 -0000
@@ -361,7 +361,7 @@
 		unsigned int slots;
 		int fmt = (runtime->format == SNDRV_PCM_FORMAT_S16_LE) ? VIA_REG_MULTPLAY_FMT_16BIT : VIA_REG_MULTPLAY_FMT_8BIT;
 		fmt |= runtime->channels << 4;
-		outb(fmt, VIA_REG_MULTPLAY_FORMAT);
+		outb(fmt, chip->port + VIA_REG_MULTPLAY_FORMAT);
 		/* set sample number to slot 3, 4, 7, 8, 6, 9 */
 		switch (runtime->channels) {
 		case 1: slots = (1<<0); break;
@@ -371,7 +371,7 @@
 		default: slots = 0;
 		}
 		/* STOP index is never reached */
-		outl(0xff000000 | slots, VIA_REG_MULTPLAY_STOP_IDX);
+		outl(0xff000000 | slots, chip->port + VIA_REG_MULTPLAY_STOP_IDX);
 	} else {
 		outl((runtime->format == SNDRV_PCM_FORMAT_S16_LE ? VIA_REG_TYPE_16BIT : 0) |
 		     (runtime->channels > 1 ? VIA_REG_TYPE_STEREO : 0) |