From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C375DC433E0 for ; Mon, 25 Jan 2021 08:02:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC91222C9F for ; Mon, 25 Jan 2021 08:02:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC91222C9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 31E14185C; Mon, 25 Jan 2021 09:01:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 31E14185C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1611561734; bh=B0UclJDIIyap5LI+z8neLbdQtF+zovEiZ9hezVGKwcQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=etSlqYCVkl/Fuf//USRq148exz3+o7P0FFFeoGOrV2XQmUBYNLtGJLpDCGMULdPPf whQ/d3NznuobqS6W37yeF/K5LiB4K/ADF/uCbiOeh6drB4PlL9QmWoazFaP2FtQVcv CLokJBlcnCg9d8zP2CfWU/6TOrg+sMOhY22ueW2E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B4DD3F8012D; Mon, 25 Jan 2021 09:01:23 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E6D51F80259; Mon, 25 Jan 2021 09:01:05 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 762C5F8012D for ; Mon, 25 Jan 2021 09:01:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 762C5F8012D X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 81329B73D; Mon, 25 Jan 2021 08:01:02 +0000 (UTC) Date: Mon, 25 Jan 2021 09:01:02 +0100 Message-ID: From: Takashi Iwai To: Jiapeng Zhong Subject: Re: [PATCH] ALSA: hda: Assign boolean values to a bool variable In-Reply-To: <1611559047-106928-1-git-send-email-abaci-bugfix@linux.alibaba.com> References: <1611559047-106928-1-git-send-email-abaci-bugfix@linux.alibaba.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: guennadi.liakhovetski@linux.intel.com, alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, tiwai@suse.com, hui.wang@canonical.com, kai.heng.feng@canonical.com, rppt@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 25 Jan 2021 08:17:27 +0100, Jiapeng Zhong wrote: > > Fix the following coccicheck warnings: > > ./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of > 0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong Thanks, applied now. But if you have some more similar changes, please try to convert at once instead of submitting each change infrequently. It's getting annoying now, as the change itself hardly helps improving the readability or code quality in general, although there is no strong reason to object it. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB8AC433E0 for ; Tue, 26 Jan 2021 03:07:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DD49230FA for ; Tue, 26 Jan 2021 03:07:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728181AbhAYMip (ORCPT ); Mon, 25 Jan 2021 07:38:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:49688 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728036AbhAYMZD (ORCPT ); Mon, 25 Jan 2021 07:25:03 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 81329B73D; Mon, 25 Jan 2021 08:01:02 +0000 (UTC) Date: Mon, 25 Jan 2021 09:01:02 +0100 Message-ID: From: Takashi Iwai To: Jiapeng Zhong Cc: perex@perex.cz, tiwai@suse.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.intel.com, guennadi.liakhovetski@linux.intel.com, kai.heng.feng@canonical.com, rppt@kernel.org, hui.wang@canonical.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda: Assign boolean values to a bool variable In-Reply-To: <1611559047-106928-1-git-send-email-abaci-bugfix@linux.alibaba.com> References: <1611559047-106928-1-git-send-email-abaci-bugfix@linux.alibaba.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jan 2021 08:17:27 +0100, Jiapeng Zhong wrote: > > Fix the following coccicheck warnings: > > ./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of > 0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong Thanks, applied now. But if you have some more similar changes, please try to convert at once instead of submitting each change infrequently. It's getting annoying now, as the change itself hardly helps improving the readability or code quality in general, although there is no strong reason to object it. Takashi