From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: usx2y: fix a memory leak bug Date: Sun, 28 Apr 2019 09:18:40 +0200 Message-ID: References: <1556433754-3291-1-git-send-email-wang6495@umn.edu> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1556433754-3291-1-git-send-email-wang6495@umn.edu> Sender: linux-kernel-owner@vger.kernel.org To: Wenwen Wang Cc: "moderated list:SOUND" , Kees Cook , Jaroslav Kysela , open list List-Id: alsa-devel@alsa-project.org On Sun, 28 Apr 2019 08:42:32 +0200, Wenwen Wang wrote: > > In usX2Y_In04_init(), a new urb is firstly created through usb_alloc_urb() > and saved to 'usX2Y->In04urb'. Then, a buffer is allocated through > kmalloc() and saved to 'usX2Y->In04Buf'. After the urb is initialized, a > sanity check is performed for the endpoint in the urb by invoking > usb_urb_ep_type_check(). If the check fails, the error code EINVAL will be > returned. In that case, however, the created urb and the allocated buffer > are not freed, leading to memory leaks. > > To fix the above issue, free the urb and the buffer if the check fails. > > Signed-off-by: Wenwen Wang Applied now, thanks. Takashi