From: Takashi Iwai <tiwai@suse.de>
To: Guillaume Fougnies <guillaume@eulerian.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] teac ud-501/ud-503 usb delay
Date: Tue, 26 Jan 2016 07:03:02 +0100 [thread overview]
Message-ID: <s5hd1soq3mx.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160125232827.GA5626@eulerian.com>
On Tue, 26 Jan 2016 00:28:27 +0100,
Guillaume Fougnies wrote:
>
> ALSA: usb: Fix TEAC UD-501/UD-503/NT-503 usb delay
>
> TEAC UD-501/UD-503/NT-503 fail to switch properly between different rate/format.
> Similar to 'Playback Design', this patch corrects the invalid clock source error
> for TEAC products and avoids complete freeze of the usb interface of 503 series.
>
> Signed-off-by: Guillaume Fougnies <guillaume@eulerian.com>
Applied, thanks.
Takashi
> ---
> sound/usb/quirks.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 23ea6d8..a75d9ce 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1205,8 +1205,12 @@ void snd_usb_set_interface_quirk(struct usb_device *dev)
> * "Playback Design" products need a 50ms delay after setting the
> * USB interface.
> */
> - if (le16_to_cpu(dev->descriptor.idVendor) == 0x23ba)
> + switch (le16_to_cpu(dev->descriptor.idVendor)) {
> + case 0x23ba: /* Playback Design */
> + case 0x0644: /* TEAC Corp. */
> mdelay(50);
> + break;
> + }
> }
>
> void snd_usb_ctl_msg_quirk(struct usb_device *dev, unsigned int pipe,
> @@ -1221,6 +1225,14 @@ void snd_usb_ctl_msg_quirk(struct usb_device *dev, unsigned int pipe,
> (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)
> mdelay(20);
>
> + /*
> + * "TEAC Corp." products need a 20ms delay after each
> + * class compliant request
> + */
> + if ((le16_to_cpu(dev->descriptor.idVendor) == 0x0644) &&
> + (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS)
> + mdelay(20);
> +
> /* Marantz/Denon devices with USB DAC functionality need a delay
> * after each class compliant request
> */
> --
> 2.7.0.rc3
>
next prev parent reply other threads:[~2016-01-26 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 16:36 [PATCH] teac ud-501/ud-503 usb delay Guillaume Fougnies
2016-01-25 10:59 ` Takashi Iwai
2016-01-25 23:28 ` Guillaume Fougnies
2016-01-26 6:03 ` Takashi Iwai [this message]
2016-03-01 0:38 ` Rob O'Donnell
2016-03-01 7:37 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd1soq3mx.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=guillaume@eulerian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.