Re: [PATCH] ALSA: hda - Remove speaker clicks on CX20549

[Takashi Iwai <tiwai@suse.de>]

At Thu, 14 Feb 2013 11:36:39 +0100,
David Henningsson wrote:
> 
> This chip needs the speaker pin to go to D3 to avoid clicks,
> so default_power_filter does not work here.
> 
> This was found on Thinkpad R61i/T61i but I guess it applies to
> the entire chip. If not, quirks should be set for at least
> PCI SSID 17aa:20ac.
> 
> Thanks to c4pp4 for testing.
> 
> BugLink: https://bugs.launchpad.net/bugs/886975
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>

Thanks, applied now.

Just wonder, though, whether rather setting
spec->gen.power_down_unused = 1 works.  When it's set, the generic
parser applies the own power filter, and it doesn't have the EAPD
check either (plus it does more aggressive power-down of unused
widgets).

Or, maybe we just drop the EAPD check, and move it to specific fixup.
AFAIK, it was required only for old Gateway laptops.


Takashi

> ---
>  sound/pci/hda/patch_conexant.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
> index 7d941ef..941bf6c 100644
> --- a/sound/pci/hda/patch_conexant.c
> +++ b/sound/pci/hda/patch_conexant.c
> @@ -3350,6 +3350,7 @@ static int patch_conexant_auto(struct hda_codec *codec)
>  	switch (codec->vendor_id) {
>  	case 0x14f15045:
>  		codec->single_adc_amp = 1;
> +		codec->power_filter = NULL; /* Needs speaker amp to D3 to avoid click */
>  		break;
>  	case 0x14f15047:
>  		codec->pin_amp_workaround = 1;
> -- 
> 1.7.9.5
>