From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932881AbWF2LX3 (ORCPT ); Thu, 29 Jun 2006 07:23:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932888AbWF2LX3 (ORCPT ); Thu, 29 Jun 2006 07:23:29 -0400 Received: from ns.suse.de ([195.135.220.2]:22761 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S932881AbWF2LX2 (ORCPT ); Thu, 29 Jun 2006 07:23:28 -0400 Date: Thu, 29 Jun 2006 13:23:22 +0200 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, perex@suse.cz Subject: Re: [Alsa-devel] [2.6 patch] fix the SND_FM801_TEA575X dependencies In-Reply-To: <20060629111058.GB29056@stusta.de> References: <20060629094944.GA29056@stusta.de> <20060629111058.GB29056@stusta.de> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 29 Jun 2006 13:10:58 +0200, Adrian Bunk wrote: > > On Thu, Jun 29, 2006 at 12:57:49PM +0200, Takashi Iwai wrote: > > At Thu, 29 Jun 2006 11:49:44 +0200, > > Adrian Bunk wrote: > > > > > > CONFIG_SND_FM801=y, CONFIG_SND_FM801_TEA575X=m resulted in the following > > > compile error: > > > > > > <-- snip --> > > > > > > ... > > > LD vmlinux > > > sound/built-in.o: In function `snd_fm801_free': > > > fm801.c:(.text+0x3c15b): undefined reference to `snd_tea575x_exit' > > > sound/built-in.o: In function `snd_card_fm801_probe': > > > fm801.c:(.text+0x3cfde): undefined reference to `snd_tea575x_init' > > > make: *** [vmlinux] Error 1 > > > > > > <-- snip --> > > > > > > This patch fixes kernel Bugzilla #6458. > > > > > > Signed-off-by: Adrian Bunk > > > > Could it be a simplier one like below? > > > Your patch would in the case of SND_FM801=m: > - build snd-tea575x-tuner.o statically into the kernel > - set VIDEO_DEV=y Ah I see. The I applied your patch to ALSA repo. Thanks. Takashi