From: Takashi Iwai <tiwai@suse.de>
To: Thierry Vignaud <tvignaud@mandriva.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] fix building alsa-tools with gtk+-2.x
Date: Thu, 04 May 2006 14:29:29 +0200 [thread overview]
Message-ID: <s5hd5eugehi.wl%tiwai@suse.de> (raw)
In-Reply-To: <m24q06x9l2.fsf@vador2.mandriva.com>
At Thu, 04 May 2006 14:23:21 +0200,
Thierry Vignaud wrote:
>
> the following patch fixes building with devel packages gtk+-2 devel
> files and not gtk+-1.2 devel files (a m4 macro was renamed between
> gtk+-1.x and gtk+-2.x):
The patch looks wrong. The relevant parts are in if-block for
gtk-1.x, and pkgconfig is used for gtk-2.x.
If you want to build only with gtk2, use configure.in-gtk2 instead.
Takashi
>
> [2 alsa-tools-1.0.11-gtk-buildfix.patch <text/x-patch (7bit)>]
> --- ./echomixer/configure.in.tv 2006-05-04 12:58:29.000000000 +0200
> +++ ./echomixer/configure.in 2006-05-04 12:57:59.000000000 +0200
> @@ -15,7 +15,7 @@
>
> else
>
> -AM_PATH_GTK(1.2.0)
> +AM_PATH_GTK_2_0(1.2.0)
> AM_PATH_ALSA(1.0.0)
> ECHOMIXER_CFLAGS="$CFLAGS $ALSA_CFLAGS $GTK_CFLAGS"
> ECHOMIXER_LIBS="$LIBS $ALSA_LIBS $GTK_LIBS"
> --- ./envy24control/configure.in.tv 2006-05-04 12:58:29.000000000 +0200
> +++ ./envy24control/configure.in 2006-05-04 12:57:59.000000000 +0200
> @@ -14,7 +14,7 @@
>
> else
>
> -AM_PATH_GTK(1.0.1)
> +AM_PATH_GTK_2_0(1.0.1)
> AM_PATH_ALSA(1.0.0)
> ENVY24CONTROL_CFLAGS="$CFLAGS $ALSA_CFLAGS $GTK_CFLAGS"
> ENVY24CONTROL_LIBS="$LIBS $ALSA_LIBS $GTK_LIBS"
> --- ./rmedigicontrol/configure.in.tv 2006-05-04 12:58:29.000000000 +0200
> +++ ./rmedigicontrol/configure.in 2006-05-04 12:57:59.000000000 +0200
> @@ -14,7 +14,7 @@
>
> else
>
> -AM_PATH_GTK(1.0.1)
> +AM_PATH_GTK_2_0(1.0.1)
> AM_PATH_ALSA(1.0.0)
> RMEDIGICONTROL_CFLAGS="$CFLAGS $ALSA_CFLAGS $GTK_CFLAGS"
> RMEDIGICONTROL_LIBS="$LIBS $ALSA_LIBS $GTK_LIBS"
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2006-05-04 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-04 12:23 [PATCH] fix building alsa-tools with gtk+-2.x Thierry Vignaud
2006-05-04 12:29 ` Takashi Iwai [this message]
2006-05-04 13:23 ` Thierry Vignaud
2006-05-04 13:31 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd5eugehi.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=tvignaud@mandriva.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.