From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] SB Live24bit: Adds support for SPDIF in. Date: Mon, 20 Dec 2004 12:41:45 +0100 Message-ID: References: <41C5EC53.70809@superbug.co.uk> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <41C5EC53.70809@superbug.co.uk> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: James Courtier-Dutton Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Sun, 19 Dec 2004 21:02:11 +0000, James Courtier-Dutton wrote: > > -static int snd_ca0106_pcm_open_capture(snd_pcm_substream_t *substream) > +static int snd_ca0106_pcm_open_0_capture(snd_pcm_substream_t *substream) > { > return snd_ca0106_pcm_open_capture_channel(substream, 0); > } You can retrieve substream->pcm->device instead of creating a callback for each device. (Or, substream->number if the pcm has multiple substreams and you need to distinguish them.) Other stuff looks fine to me. Oh one thing forgotten: could you provide signed-off-by line, too? thanks, Takashi ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/