Re: ALSA Driver for Sparc DBRI chips

[Takashi Iwai <tiwai@suse.de>]

At Thu, 25 Nov 2004 15:01:56 +0100,
I wrote:
> 
> [1  <text/plain; US-ASCII (7bit)>]
> At Sun, 21 Nov 2004 09:50:08 +0000,
> Martin Habets wrote:
> > 
> > Hi,
> > 
> > I have been working on an ALSA driver for the DBRI/CS4215 chip
> > combo found in Sparc machines. It is a port of the 2.5 OSS driver.
> > 
> > Things are starting to work, but since this is my first major
> > undertaking I'm looking for your comments. Ask early, ask often...
> > At this point I expect playback to work to all possible outputs (there
> > is some clipping on 16 bit formats). I have not been able to get recording
> > output in a file, though it does seem to catch data.
> > 
> > So I look for anything from coding style to design issues to spelling to
> > 'it worked' to 'I get an error' to the-meaning-of-the-universe.
> > Just keep the phasers on stun, please :)
> 
> Thanks for the patch.
> 
> I modified some codes to adapt to the latest 2.6.10-rc2, and reduced
> compile warnings (just checked with the cross-compile environment.)
> ALso, the spin_lock() is changed to spin_lock_irq() in the prepare
> callback since the recent version is it became non-atomic.
> The patch is below.

One thing forgot:  the proc write for debug option isn't necessary.
You can do the same via sysfs when you set the write permission to the
option.


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/