From: Takashi Iwai <tiwai@suse.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, perex@suse.de
Subject: Re: ALSA update broke Sparc
Date: Wed, 01 Sep 2004 10:12:39 +0200 [thread overview]
Message-ID: <s5hd616z9u0.wl@alsa2.suse.de> (raw)
In-Reply-To: <20040831135651.0da4dc5d.davem@davemloft.net>
At Tue, 31 Aug 2004 13:56:51 -0700,
David S. Miller wrote:
>
> On Tue, 31 Aug 2004 21:07:19 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
>
> > I fixed/updated the ALSA pcm layer.
> >
> > David, could you try the attached patch? With this, the problematic
> > part will be disabled on sparc (it won't work on every architecture,
> > anyway).
>
> Generates lots of warnings like this:
>
> CC [M] drivers/i2c/chips/smsc47m1.o
> In file included from sound/pci/au88x0/au88x0.h:26,
> from sound/pci/au88x0/au8820.c:2:
> include/sound/pcm.h:960:1: warning: "SNDRV_PCM_INFO_MMAP" redefined
> In file included from include/sound/pcm.h:26,
> from sound/pci/au88x0/au88x0.h:26,
> from sound/pci/au88x0/au8820.c:2:
> include/sound/asound.h:264:1: warning: this is the location of the previous definition
Sorry, a silly typo.
Takashi
--- linux/include/sound/pcm.h-dist 2004-09-01 10:10:16.038394555 +0200
+++ linux/include/sound/pcm.h 2004-09-01 10:10:21.377184781 +0200
@@ -957,7 +957,7 @@ static inline void snd_pcm_mmap_data_clo
#define SNDRV_PCM_INFO_MMAP_IOMEM SNDRV_PCM_INFO_MMAP
int snd_pcm_lib_mmap_iomem(snd_pcm_substream_t *substream, struct vm_area_struct *area);
#else
-#define SNDRV_PCM_INFO_MMAP 0
+#define SNDRV_PCM_INFO_MMAP_IOMEM 0
#define snd_pcm_lib_mmap_iomem NULL
#endif
next prev parent reply other threads:[~2004-09-01 8:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-28 1:36 ALSA update broke Sparc David S. Miller
2004-08-28 7:45 ` Russell King
2004-08-30 10:26 ` Takashi Iwai
2004-08-31 19:07 ` Takashi Iwai
2004-08-31 20:56 ` David S. Miller
2004-09-01 8:12 ` Takashi Iwai [this message]
2004-08-31 20:58 ` David S. Miller
2004-09-01 8:14 ` Takashi Iwai
2004-08-31 22:20 ` Andrew Morton
2004-09-01 8:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hd616z9u0.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.