[PATCH] fix SB crash

[PATCH] fix SB crash

[Clemens Ladisch]

snd_ctl_new1() is called from snd_sbmixer_add_ctl() with ncontrol->name
set to NULL.


Index: core/control.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/core/control.c,v
retrieving revision 1.26
diff -u -r1.26 control.c
--- core/control.c	7 Jan 2003 12:27:45 -0000	1.26
+++ core/control.c	13 Jan 2003 08:19:27 -0000
@@ -211,7 +211,8 @@
 	kctl.id.iface = ncontrol->iface;
 	kctl.id.device = ncontrol->device;
 	kctl.id.subdevice = ncontrol->subdevice;
-	strncpy(kctl.id.name, ncontrol->name, sizeof(kctl.id.name)-1);
+	if (ncontrol->name)
+		strncpy(kctl.id.name, ncontrol->name, sizeof(kctl.id.name)-1);
 	kctl.id.index = ncontrol->index;
 	kctl.access = ncontrol->access == 0 ? SNDRV_CTL_ELEM_ACCESS_READWRITE :
 		      (ncontrol->access & (SNDRV_CTL_ELEM_ACCESS_READWRITE|SNDRV_CTL_ELEM_ACCESS_INACTIVE|SNDRV_CTL_ELEM_ACCESS_INDIRECT));



-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

Re: [PATCH] fix SB crash

[Takashi Iwai]

At Mon, 13 Jan 2003 09:25:01 +0100 (MET),
Clemens Ladisch wrote:
> 
> 
> snd_ctl_new1() is called from snd_sbmixer_add_ctl() with ncontrol->name
> set to NULL.

oh, thanks for spotting it out.
applied to cvs.


Takashi


-------------------------------------------------------
This SF.NET email is sponsored by: FREE  SSL Guide from Thawte
are you planning your Web Server Security? Click here to get a FREE
Thawte SSL guide and find the answers to all your  SSL security issues.
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en